Skip to content

Support Baiducloud Cloud Provider for cluster-autoscaler #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Support Baiducloud Cloud Provider for cluster-autoscaler #1536

merged 1 commit into from
Jan 10, 2019

Conversation

@hello2mao
Copy link
Contributor

@hello2mao hello2mao commented Dec 26, 2018 •
edited
Loading

What this PR does / why we need it:
BaiduCloud Container Engine is a high-performance and scalable container application management service using Kubernetes.
As the gold member of Kubernetes community, we create this PR to support Baiducloud Cloud Provider for cluster-autoscaler.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 26, 2018
@hello2mao
Copy link
Contributor Author

hello2mao commented Dec 26, 2018

@tizhou86

@hello2mao
Copy link
Contributor Author

hello2mao commented Dec 26, 2018

cc @mwielgus

@mwielgus mwielgus self-assigned this Jan 10, 2019
@mwielgus
Copy link
Contributor

mwielgus commented Jan 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2019
@mwielgus
Copy link
Contributor

mwielgus commented Jan 10, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2d3145c into kubernetes:master Jan 10, 2019
@mwielgus
Copy link
Contributor

mwielgus commented Jan 10, 2019

@hello2mao I assume that you will be the main contact point for Baidu-related issues/prs.

@hello2mao
Copy link
Contributor Author

hello2mao commented Jan 10, 2019

@mwielgus Yes, @tizhou86 and I will be the maintainers for Baidu-related issues.

@mwielgus
Copy link
Contributor

mwielgus commented Jan 11, 2019 •
edited
Loading

Cool, can you add your contact details (github, mail or slack handle) to the Readme file so that people reporting problems/asking questions have an easier job?

@hello2mao
Copy link
Contributor Author

hello2mao commented Jan 11, 2019

Cool, can you add your contact details (github, mail or slack handle) to the Readme file so that people reporting problems/asking questions have an easier job?

OK, I will add some information later.

@hello2mao hello2mao mentioned this pull request Feb 14, 2019
Closed
6 tasks
@ysy2020 ysy2020 mentioned this pull request Jul 20, 2020
Merged
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
@dependabot
Bump k8s.io/metrics from 0.28.4 to 0.28.5 (kubernetes#1536)
8846a37 
Bumps [k8s.io/metrics](https://github.com/kubernetes/metrics) from 0.28.4 to 0.28.5.
- [Commits](kubernetes/metrics@v0.28.4...v0.28.5)

---
updated-dependencies:
- dependency-name: k8s.io/metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@piosz piosz Awaiting requested review from piosz

1 more reviewer

@mwielgus mwielgus mwielgus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mwielgus mwielgus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello2mao @mwielgus @k8s-ci-robot @bskiba