devel/scheduler: update intro and scheduling algo #164
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
@timothysc @davidopp |
|
Yes, please ask the contribex SIG when they are going to do that, as they are responsible for the move. |
|
Assigning @timothysc @davidopp as we discussed in 1.6 code health plan. |
|
👍 as a newbie this documentation update looks nice to me. Especially the new ascii art should get a place on my wall. My 2ct. |
|
I'll assign @jayunit100 b/c he last updated the doc. |
|
thanks @hongchaodeng couple minor comments, otherwise lg ! |
|
@jayunit100 |
|
just added |
contributors/devel/scheduler.md
Outdated
| indicating where the Pod should be scheduled. | ||
| The Kubernetes scheduler runs as a process alongside the other master components such as the API server. | ||
| Its interface to the API server is to watch for Pods with an empty PodSpec.NodeName, | ||
| and for each Pod, it posts a Binding indicating where the Pod should be scheduled. |
contributors/devel/scheduler.md
Outdated
| - [pkg/scheduler/scheduler.go](http://releases.k8s.io/HEAD/pkg/scheduler/scheduler.go): | ||
| This is the scheduler framework that handles stuff (e.g. binding) beyond the scheduling algorithm. | ||
| - [pkg/scheduler/generic_scheduler.go](http://releases.k8s.io/HEAD/pkg/scheduler/generic_scheduler.go): | ||
| This is the scheduling algorithm that basically assigns nodes for pods. |
There was a problem hiding this comment.
The scheduling algorithm that assigns nodes for pods.
contributors/devel/scheduler.md
Outdated
| | | ||
| v | ||
| +-------------------+-------------------------+ | ||
| | left nodes: | |
There was a problem hiding this comment.
change "left nodes" to "remaining nodes" ..
| for Pods with an empty PodSpec.NodeName, and for each Pod, it posts a Binding | ||
| indicating where the Pod should be scheduled. | ||
| The Kubernetes scheduler runs as a process alongside the other master components such as the API server. | ||
| Its interface to the API server is to watch for Pods with an empty PodSpec.NodeName, |
There was a problem hiding this comment.
it's (not your fault, it existed before :) but might as well fix now right :)
There was a problem hiding this comment.
Can you read again? It should be "Its interface to the ... is to".
There was a problem hiding this comment.
@jayunit100
I see no problem in this sentence:
"Its interface to the API server is to watch..."
Can you clarify what it should be?
|
@hongchaodeng (1) fix the one other |
|
Thanks @jayunit100 for review. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@wojtek-t can you please review this? |
|
Thanks @jayunit100 @davidopp . |
* VM memory dump design proposal Signed-off-by: Shelly Kagan <[email protected]> * design review fixes Signed-off-by: Shelly Kagan <[email protected]> * Add more details on the subresource command Signed-off-by: Shelly Kagan <[email protected]> * Add vm yaml with memory dump information Signed-off-by: Shelly Kagan <[email protected]> * other review changes Signed-off-by: Shelly Kagan <[email protected]>
7 participants
This is to update scheduler.md to make it easier for new dev to understand: