Add Volume Snapshot Support #1662
Conversation
k8s-ci-robot
added
size/XL
k8s-github-robot
added
the
sig/storage
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
k8s-github-robot
added
the
kind/design
| * Determine the correct volume snapshot plugin to use from the `VolumeSnapshotData` referenced by the | ||
| `VolumeSnapshot` | ||
|
|
||
| * Create a delete operation: only one such operation is allowed to exist for the given `VolumeSnapshot` and |
There was a problem hiding this comment.
If the controller stopped before we delete VolumeSnapshotData, according VolumeSnapshot no longer exists in ASW after controller started again, and the VolumeSnapshotData will be orphaned. Maybe we need an asynchronous go routine to clean up these VolumeSnapshotDatas.
xing-yang
force-pushed
the
snapshot
branch
3 times, most recently
from
171d06c to
29a3fa3
Compare
|
/test pull-community-verify |
|
/retest |
xing-yang
force-pushed
the
snapshot
branch
2 times, most recently
from
b2dea28 to
8c9aa66
Compare
This document proposes to add Kubernetes snapshot support in-tree.
|
cc @thockin PTAL |
|
/assign @jsafrane @saad-ali @thockin @bgrant0607 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR moves snapshot APIs in-tree and also adds a snapshot controller in-tree. The design proposal is here: kubernetes/community#1662
|
We are going to use CRD instead of in-tree APIs. A new PR is submitted here: #2335. Closing this one. |
10 participants
This document proposes to add Kubernetes snapshot support in-tree.