Skip to content

Conversation

@Rishit-dagli
Copy link
Contributor

Adds the SIG docs: New Contributors Meet and Greet events as suggested by @sftim

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Rishit-dagli / name: Rishit Dagli (3707a37)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Rishit-dagli!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Rishit-dagli. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm May 31, 2022 18:46
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 31, 2022
@sftim
Copy link

sftim commented Jun 1, 2022

Thanks!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2022
Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing this file, change the source, commit that change. Next, then run make generate-dockerized and commit the changes you get.

See https://github.com/kubernetes/community/blob/master/generator/README.md#how-to-use for more tips.

@Rishit-dagli
Copy link
Contributor Author

Ah, missed this. Thanks for pointing this out!

@Rishit-dagli Rishit-dagli requested a review from sftim June 1, 2022 15:39
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2022
@Rishit-dagli Rishit-dagli force-pushed the Rishit-dagli-patch-1 branch from 6851071 to 82bac15 Compare June 1, 2022 15:41
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding the Youtube link for the meeting recordings since they'll be available. You'll, of course, need to make changes to the sigs.yaml file again.

Copy link

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 24, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2022
@Rishit-dagli
Copy link
Contributor Author

/retest

@Rishit-dagli
Copy link
Contributor Author

The merge conflicts are now fixed!

To complete the pull request process, please assign nikhita after the PR has been reviewed.

/assign @nikhita

@Rishit-dagli Rishit-dagli requested a review from reylejano July 9, 2022 06:26
@Rishit-dagli
Copy link
Contributor Author

@reylejano 627aed3 and 379fbe3 address your reviews

@nikhita
Copy link
Member

nikhita commented Jul 11, 2022

/unassign

Please reassign back to me when this has LGTM from SIG Docs leads. Thanks!

@reylejano
Copy link
Member

/lgtm
lgtm's from 2 SIG Docs co-chairs (myself and Divya) and 1 SIG Docs tech lead (Tim)
/assign @nikhita

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@mrbobbytables mrbobbytables added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 7, 2022
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I've added the tide squash label, but please rebase and fixup and PRs with the WIP type commits in the future. It's less critical here in k/community, but can be a blocker in other repos.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, Rishit-dagli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit a386c1b into kubernetes:master Sep 7, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-patch-1 branch September 7, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants