-
Couldn't load subscription status.
- Fork 5.3k
Add SIG docs: New Contributors Meet and Greet #6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SIG docs: New Contributors Meet and Greet #6679
Conversation
|
|
|
Welcome @Rishit-dagli! |
|
Hi @Rishit-dagli. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks! /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of changing this file, change the source, commit that change. Next, then run make generate-dockerized and commit the changes you get.
See https://github.com/kubernetes/community/blob/master/generator/README.md#how-to-use for more tips.
|
Ah, missed this. Thanks for pointing this out! |
6851071 to
82bac15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider adding the Youtube link for the meeting recordings since they'll be available. You'll, of course, need to make changes to the sigs.yaml file again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
|
/retest |
|
The merge conflicts are now fixed!
/assign @nikhita |
|
@reylejano 627aed3 and 379fbe3 address your reviews |
|
/unassign Please reassign back to me when this has LGTM from SIG Docs leads. Thanks! |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I've added the tide squash label, but please rebase and fixup and PRs with the WIP type commits in the future. It's less critical here in k/community, but can be a blocker in other repos.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrbobbytables, Rishit-dagli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds the SIG docs: New Contributors Meet and Greet events as suggested by @sftim