Skip to content

Promote Portworx CSI migration to Beta in v1.24 #3187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Promote Portworx CSI migration to Beta in v1.24 #3187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion keps/prod-readiness/sig-storage/2589.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
kep-number: 2589
alpha:
approver: "@ehashman"
approver: "@ehashman"
beta:
Copy link
Member

@msau42 msau42 Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the alpha entry and add a new beta entry with @wojtek-t as the reviewer

Copy link
Contributor Author

@trierra trierra Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, let me fix that

Copy link
Member

@wojtek-t wojtek-t Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - as Michelle wrote. Please don't change the existing entries - just add a new one.

Copy link
Contributor Author

@trierra trierra Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t done

approver: "@wojtek-t"
6 changes: 4 additions & 2 deletions keps/sig-storage/2589-csi-migration-portworx/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ This document present as a vendor specific KEP for the parent KEP
[CSI Migration](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration)

This inherits all the contents from its parent KEP. It will introduce two new feature gates to be
used as as described in its parent KEP. For all other contents, please refer to the parent KEP.
used as described in its parent KEP. For all other contents, please refer to the parent KEP.

### New Feature Gates

- CSIMigrationPortworx
- As describe in [CSI Migration](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration),
when this feature flag && the `CSIMigration` is enabled at the same time, the in-tree volume
plugin `kubernetes.io/portworx-volume` will be redirect to use the corresponding CSI driver. From a
plugin `kubernetes.io/portworx-volume` will be redirected to use the corresponding CSI driver. From a
user perspective, nothing will be noticed.
- InTreePluginPortworxUnregister
- This flag technically is not part of CSI Migration design. But it happens to be related and helps with
Expand All @@ -50,4 +50,6 @@ Major milestones for Portworx in-tree plugin CSI migration:

- 1.23
- Portworx CSI migration to Alpha
- 1.24
- Portworx CSI migration to Beta, off by default

4 changes: 2 additions & 2 deletions keps/sig-storage/2589-csi-migration-portworx/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ prr-approvers:
replaces:

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
stage: beta

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.23"
latest-milestone: "v1.24"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
Expand Down