Skip to content

Conversation

@robscott
Copy link
Member

@robscott robscott commented Oct 7, 2023

  • One-line PR description: As @npolshakova pointed out, our metadata for this KEP is out of date, this fixes that.

  • Issue link: Topology Aware Routing #2433

  • Other comments: We're not making any changes to the KEP in this cycle, just trying to get the implementation to catch up to the KEP.

/sig network
/assign @thockin

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2023
@robscott robscott mentioned this pull request Oct 7, 2023
20 tasks
@thockin
Copy link
Member

thockin commented Oct 7, 2023

I thought we were NOT going GA until we had the other mode implemented?

@robscott
Copy link
Member Author

robscott commented Oct 7, 2023

@thockin yep, that's correct, that's exactly what this update is trying to say even though that wasn't very clear. Essentially we had previously targeted the upcoming 1.29 release as the "stable" target and that's what the KEP metadata said. This updates it to more clearly state that "stable" is not until at least 1.30 and we're staying in beta for 1.29.

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I misread it before

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit c90067e into kubernetes:master Oct 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants