Skip to content

KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 13, 2025
Merged

KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen #5074

merged 18 commits into from
Feb 13, 2025

Conversation

@aaron-prindle
Copy link
Contributor

One-line PR description: Implement declarative validation of Kubernetes native types using validation-gen to generate validation code.
Issue link: #5073

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and sttts January 22, 2025 19:33
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2025
@aaron-prindle aaron-prindle mentioned this pull request Jan 22, 2025
Open
24 tasks
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 3 times, most recently from 73f9dcd to fdcec1b Compare January 22, 2025 19:56
@aaron-prindle aaron-prindle mentioned this pull request Jan 22, 2025
Open
15 tasks
@jpbetz
Copy link
Contributor

jpbetz commented Jan 22, 2025

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 22, 2025
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 2 times, most recently from 996751a to b31c75f Compare January 22, 2025 20:55
@aaron-prindle
Copy link
Contributor Author

aaron-prindle commented Jan 22, 2025 •
edited
Loading

/cc @deads2k @liggitt @msau42 @thockin

NOTE: adding @msau42 and @thockin from api-reviewers given a goal of the KEP is to streamline API reviews (not for an API review on the KEP itself)

@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch from b31c75f to c1bce5a Compare January 23, 2025 01:13
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 5 times, most recently from ab4fe70 to 68fe8c5 Compare January 23, 2025 22:55
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 4 times, most recently from e120fb9 to 0f7fb65 Compare February 12, 2025 00:54
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch from 0f7fb65 to 3492567 Compare February 12, 2025 00:58
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 5 times, most recently from 961e3df to c831278 Compare February 12, 2025 19:16
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch from c831278 to b55057c Compare February 12, 2025 19:25
@aaron-prindle aaron-prindle mentioned this pull request Feb 12, 2025
Merged
@deads2k
Copy link
Contributor

deads2k commented Feb 13, 2025

/lgtm

/hold

holding for other reviewers, but without a nak I plan to merge tomorrow.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@deads2k deads2k added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 13, 2025
@deads2k
Copy link
Contributor

deads2k commented Feb 13, 2025

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, deads2k, jpbetz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a5d411 into kubernetes:master Feb 13, 2025
4 checks passed
@aaron-prindle aaron-prindle mentioned this pull request Feb 14, 2025
Merged
yliaog pushed a commit to yliaog/enhancements that referenced this pull request Mar 7, 2025
@aaron-prindle @yongruilin
@jpbetz @yliaog
KEP-5073: Declarative Validation of Kubernetes Native Types With vali…
e298cd7 
…dation-gen (kubernetes#5074)

* KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen

* resolving KEP comments

* resolving KEP comments round kubernetes#2

* resolving KEP comments round kubernetes#3

* update KEP-5073 to clarify migration details

* fix prototype link in a # of places

* Propose a runtime verification check

* Update TOC

* move runtime check section

* plumb DeclarativeValidationMismatchMetrics feature gate through KEP

* resolving KEP comments round kubernetes#4

* update reviewers and approvers

* resolving KEP comments round kubernetes#5

* resolving KEP comments round kubernetes#6

* remove recommended and unresovled from zero values + defaulting section

* fix metric name

---------

Co-authored-by: yongruilin <[email protected]>
Co-authored-by: Joe Betz <[email protected]>
@aaron-prindle aaron-prindle mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly pohly left review comments

@jpbetz jpbetz jpbetz left review comments

@thockin thockin thockin approved these changes

@deads2k deads2k deads2k requested changes

@johnbelamaric johnbelamaric johnbelamaric left review comments

@sttts sttts Awaiting requested review from sttts

@liggitt liggitt Awaiting requested review from liggitt

@msau42 msau42 Awaiting requested review from msau42

+2 more reviewers

@robscott robscott robscott left review comments

@yongruilin yongruilin yongruilin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thockin thockin

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lead-opted-in Denotes that an issue has been opted in to a release lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

10 participants

@aaron-prindle @jpbetz @bowei @thockin @deads2k @k8s-ci-robot @pohly @robscott @johnbelamaric @yongruilin