Skip to content

Conversation

@aaron-prindle
Copy link
Contributor

One-line PR description: This addresses how we intend to handle immutability related validations with Declarative Validation.

Issue link: #5073

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2025
@aaron-prindle
Copy link
Contributor Author

/assign @deads2k @jpbetz @thockin
/cc @yongruilin

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from apelisse and sttts June 4, 2025 21:50
@k8s-ci-robot k8s-ci-robot requested a review from yongruilin June 4, 2025 21:50
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2025
@aaron-prindle aaron-prindle force-pushed the kep-5073-update-immutability branch 2 times, most recently from 5592bea to df8d3d2 Compare June 4, 2025 21:57
@aaron-prindle aaron-prindle force-pushed the kep-5073-update-immutability branch from df8d3d2 to c45b841 Compare June 4, 2025 22:08
Copy link
Contributor

@deads2k deads2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write up. The table is extremely helpful. One question to confirm I've understood it properly and lgtm.

@deads2k
Copy link
Contributor

deads2k commented Jun 5, 2025

/lgtm

/assign @jpbetz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Jun 5, 2025

/approve

I've been tracking this design for a while. Happy with where it landed.

Thanks @aaron-prindle

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit c0886bb into kubernetes:master Jun 5, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants