- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.6k
 
KEP-5073: Declarative Validation: Explain and update document with immutability validation information #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-5073: Declarative Validation: Explain and update document with immutability validation information #5373
Conversation
| 
           /assign @deads2k @jpbetz @thockin  | 
    
5592bea    to
    df8d3d2      
    Compare
  
    …mutability validation information
df8d3d2    to
    c45b841      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write up. The table is extremely helpful. One question to confirm I've understood it properly and lgtm.
        
          
                keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md
          
            Show resolved
            Hide resolved
        
      | 
           /lgtm /assign @jpbetz  | 
    
| 
           /approve I've been tracking this design for a while. Happy with where it landed. Thanks @aaron-prindle  | 
    
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaron-prindle, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
One-line PR description: This addresses how we intend to handle immutability related validations with Declarative Validation.
Issue link: #5073