Skip to content

Adds [email protected] group #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

Adds [email protected] group #400

merged 1 commit into from
Dec 6, 2019

Conversation

@claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Oct 16, 2019

The group is meant to own pushing rights to the gcr.io/kubernetes-staging-e2e-test-images registry, which will contain the images to be promoted to the gcr.io/kubernetes-e2e-test-images registry.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2019

Welcome @BCLAU!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2019
nikhita
nikhita reviewed Oct 16, 2019
View reviewed changes
thockin
thockin reviewed Oct 16, 2019
View reviewed changes
infra/gcp/ensure-staging-storage.sh Outdated
coredns
csi
descheduler
e2e-test-images
Copy link
Member

@thockin thockin Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get one shot at naming. Does "images" add enough value here, or is "e2e-test" or "test-e2e" or "testing/e2e" or even just "e2e" sufficient?

Copy link
Contributor Author

@claudiubelu claudiubelu Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the name needs to be shortened?

If so, I'd rather go with e2e-test, unless you're suggesting otherwise.

thockin
thockin reviewed Oct 16, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than naming, this seems good.

I assume you want the second part, which is the Prow config to enable auto-build and auto-push thru GCB.

@Katharine do you have a template PR or docs on how to enable this? We should embed that into https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/README.md

@Katharine
Copy link
Member

Katharine commented Oct 16, 2019

@thockin https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#prow-config-template

claudiubelu
claudiubelu commented Oct 16, 2019
View reviewed changes
Copy link
Contributor Author

@claudiubelu claudiubelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're going to need another 2 PRs:

  • PR that adds cloudbuild.yaml in kubernetes/kubernetes
  • PR in kubernetes/test-infra containing a prow job config.

Will try to send them in the morning,

infra/gcp/ensure-staging-storage.sh Outdated
coredns
csi
descheduler
e2e-test-images
Copy link
Contributor Author

@claudiubelu claudiubelu Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the name needs to be shortened?

If so, I'd rather go with e2e-test, unless you're suggesting otherwise.

@claudiubelu claudiubelu mentioned this pull request Oct 17, 2019
Merged
@claudiubelu
Copy link
Contributor Author

claudiubelu commented Oct 17, 2019 •
edited
Loading

I've sent the other 2 required PRs:

kubernetes/kubernetes#84058
kubernetes/test-infra#14833

Hopefully I got it right.

@claudiubelu claudiubelu mentioned this pull request Oct 23, 2019
Merged
@claudiubelu
Adds [email protected] group
c4bdc36 
The group is meant to own pushing rights to the gcr.io/k8s-staging-e2e-test-images
registry, which will contain the images to be promoted to the gcr.io/kubernetes-e2e-test-images
registry.
This was referenced Oct 25, 2019
Merged
Closed
cblecker
cblecker requested changes Oct 25, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

groups/groups.yaml changes need to be rebased and brought in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2019
@claudiubelu
Copy link
Contributor Author

claudiubelu commented Oct 29, 2019

/hold

groups/groups.yaml changes need to be rebased and brought in

done

@smourapina
Copy link

smourapina commented Oct 30, 2019

/milestone v1.17

Adding to milestone 1.17, as suggested in kubernetes/kubernetes#81170 (comment)

@claudiubelu
Copy link
Contributor Author

claudiubelu commented Nov 11, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@dims
Copy link
Member

dims commented Dec 6, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1f9a39b into kubernetes:master Dec 6, 2019
@claudiubelu claudiubelu mentioned this pull request Jan 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhita nikhita nikhita left review comments

@cblecker cblecker cblecker requested changes

+1 more reviewer

@thockin thockin thockin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@claudiubelu @k8s-ci-robot @Katharine @smourapina @dims @cblecker @thockin @nikhita