-
Notifications
You must be signed in to change notification settings - Fork 937
promote baseimage built by pr 8870 #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Did this image build just because we fixed the CI, or did we actually make some changes? |
|
This image was built only because of CI change. Also, this is cleaner execution as per build history because then we will be consistent with the registry's latest image. Alternative is to put the one previous build's sha here so NGINX_BASE file will have the sha not from the latest images in the registry. Waiting for this eagerly so that we can get up to date on the important other images like e2e-test-runner with ginkgo2 and cfssl etc. |
|
And only after after this we will get the patch of busybox + ssl_client CVE. Then whenever possible , the cherrypick to the branch 1.3 can happen to cut a controller v1.3.1 release with CVE fixes (among other changes). I am eager to see results of e2e with ginkgo2 changes |
|
And we also need a Golang bump as per dims mail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @tao12345666333 @rikatz @strongjz