Skip to content

Conversation

@longwuyuan
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jul 27, 2022
@tao12345666333
Copy link
Member

Thanks! Did this image build just because we fixed the CI, or did we actually make some changes?

@longwuyuan
Copy link
Contributor Author

This image was built only because of CI change.
But we should use this image because although this is a rebuild based on alpine v3.16.1, it will have patched binaries that are more recent than the one build before this (that was also v3.16.1).

Also, this is cleaner execution as per build history because then we will be consistent with the registry's latest image. Alternative is to put the one previous build's sha here so NGINX_BASE file will have the sha not from the latest images in the registry.

Waiting for this eagerly so that we can get up to date on the important other images like e2e-test-runner with ginkgo2 and cfssl etc.

@longwuyuan
Copy link
Contributor Author

And only after after this we will get the patch of busybox + ssl_client CVE. Then whenever possible , the cherrypick to the branch 1.3 can happen to cut a controller v1.3.1 release with CVE fixes (among other changes). I am eager to see results of e2e with ginkgo2 changes

@longwuyuan
Copy link
Contributor Author

And we also need a Golang bump as per dims mail

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0ed690a into kubernetes:main Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 1, 2022
@longwuyuan longwuyuan deleted the update-baseimage branch August 1, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants