Skip to content

registry.k8s.io: Add a BigQuery DataSet for logs #4133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2022
Merged

registry.k8s.io: Add a BigQuery DataSet for logs #4133

merged 3 commits into from
Aug 24, 2022

Conversation

@ameukam
Copy link
Member

@ameukam ameukam commented Aug 24, 2022

Add a BigQuery DataSet for logs storage of all the requests sent to registry.k8s.io.

Signed-off-by: Arnaud Meukam [email protected]

ameukam added 3 commits August 24, 2022 19:12
@ameukam
Bump Google provider
3025c11 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Bump required version of terraform
5975818 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
registry.k8s.io: Add a BigQuery DataSet for logs
7c36417 
Add a BigQuery DataSet for logs storage of all the requests sent
registry.k8s.io

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 24, 2022

cc @dims

/label tide/method-merge-squash

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 24, 2022

@ameukam: The label(s) /label tide/method-merge-squash cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

cc @dims

/label tide/method-merge-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from thockin August 24, 2022 17:18
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 24, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 24, 2022
@dims
Copy link
Member

dims commented Aug 24, 2022

/approve
/lgtm
/hold until you need it merged!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Aug 24, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8ab3e6f into kubernetes:main Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 24, 2022
@ameukam
Copy link
Member Author

ameukam commented Aug 24, 2022

Deployment done:

google_bigquery_dataset.registry_k8s_io_logs: Creating...
google_bigquery_dataset.registry_k8s_io_logs: Creation complete after 3s [id=projects/k8s-infra-public-pii/datasets/registry_k8s_io_logs]

ameukam added a commit to ameukam/k8s.io that referenced this pull request Aug 25, 2022
@ameukam
registry.k8s.io: Add a Logs router sink
b9e616e 
Follow-up of:
  - kubernetes#4133

Add a Logs router sink to ensure Cloud Run logs are forwarded to a
BigQuery dataset.
An IAM permission is granted to the sink to write logs in the dataset.

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam mentioned this pull request Aug 25, 2022
Merged
@hakman hakman mentioned this pull request Aug 31, 2022
Closed
@ameukam
Copy link
Member Author

ameukam commented Sep 2, 2022

Ref: #3411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.25

Development

Successfully merging this pull request may close these issues.

3 participants

@ameukam @k8s-ci-robot @dims