Skip to content

Automated cherry pick of #16583: Make ASG Warmpool depend on ASG Lifecycle hook #16603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Automated cherry pick of #16583: Make ASG Warmpool depend on ASG Lifecycle hook #16603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions upup/pkg/fi/cloudup/awstasks/warmpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,28 @@ type WarmPool struct {
AutoscalingGroup *AutoscalingGroup
}

var _ fi.CloudupHasDependencies = &WarmPool{}

// Warmpool depends on any Lifecycle hooks being in place first.
func (e *WarmPool) GetDependencies(tasks map[string]fi.CloudupTask) []fi.CloudupTask {
var deps []fi.CloudupTask

// Depend on the ASG.
if e.AutoscalingGroup != nil {
deps = append(deps, e.AutoscalingGroup)
}

// Depend on any Lifecycle hooks assigned to the ASG.
for _, task := range tasks {
if l, ok := task.(*AutoscalingLifecycleHook); ok {
if l.AutoscalingGroup == e.AutoscalingGroup {
deps = append(deps, task)
}
}
}
return deps
}

// Find is used to discover the ASG in the cloud provider.
func (e *WarmPool) Find(c *fi.CloudupContext) (*WarmPool, error) {
ctx := c.Context()
Expand Down