Skip to content

Enforce GCP limit of 64 chars for cluster name in kubetest2 deployer #16787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Enforce GCP limit of 64 chars for cluster name in kubetest2 deployer #16787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/e2e/kubetest2-kops/deployer/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,14 @@ func defaultClusterName(cloudProvider string) (string, error) {
jobName = jobName[:79]
}
if jobType == "presubmit" {
return fmt.Sprintf("e2e-pr%s.%s.%s", pullNumber, jobName, suffix), nil
jobName = fmt.Sprintf("e2e-pr%s.%s.%s", pullNumber, jobName, suffix)
} else {
jobName = fmt.Sprintf("e2e-%s.%s", jobName, suffix)
}
return fmt.Sprintf("e2e-%s.%s", jobName, suffix), nil
if len(jobName) > 63 && cloudProvider == "gce" { // GCP has char limit of 64
jobName = jobName[:63]
}
return jobName, nil
}

// stateStore returns the kops state store to use
Expand Down