Skip to content

Conversation

@jsafrane
Copy link
Member

@jsafrane jsafrane commented Sep 2, 2024

Implement SELinuxMount feature gate for GCE.

I tested it on GCE + RockyLinux,

(for my future self: KOPS_FEATURE_FLAGS=SELinuxMount kops create cluster ${DOMAIN} --zones us-central1-a --state ${KOPS_STATE_STORE}/ --project=${PROJECT} --set=cluster.spec.cloudProvider.gce.useStartupScript=true --image=rocky-linux-cloud/rocky-linux-9-optimized-gcp-v20240717 --yes --set=cluster.spec.containerd.selinuxEnabled=true)

@k8s-ci-robot k8s-ci-robot requested a review from hakman September 2, 2024 16:24
@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from zetaab September 2, 2024 16:24
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2024
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @jsafrane. 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit adce725 into kubernetes:master Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants