Ignore blackhole NAT routes #16879
Merged
Ignore blackhole NAT routes #16879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Oct 6, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
This was referenced Oct 6, 2024
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 6, 2024
…-upstream-release-1.29 Automated cherry pick of #16879: Ignore blackhole NAT routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve kops' handling of NAT gateways being deleted. If a NAT gateway is present in a route table and it is deleted, the route remains but with a state of
blackhole. When kops discovers NAT gateways it discovers them via route table. This means a deleted NAT Gateway could still be recognized by kops, leading to 404s in subsequent API calls.Now kops will ignore such NAT Gateways and should report needing to create a replacement. route.go will also correctly handle replacing the blackhole'd route in the route table.