fix get assets #17385
Merged
fix get assets #17385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/provider/aws
We were skipping tasks in `kops get assets`; but this meant we would not discover assets for skipped tasks. We are doing a dry-run here, so introduce a dry-run mode that does not look for existing resources. That is essentially as fast as skipping the task, but means we visit all tasks.
Member
|
/retest |
hakman
approved these changes
May 3, 2025
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 3, 2025
Closed
k8s-ci-robot
added a commit
that referenced
this pull request
May 3, 2025
…-upstream-release-1.32 Automated cherry pick of #17385: tests: add tests for kubectl get assets
k8s-ci-robot
added a commit
that referenced
this pull request
May 3, 2025
…-upstream-release-1.31 Automated cherry pick of #17385: tests: add tests for kubectl get assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: add tests for kubectl get assets
fix kops get cluster for files
We were skipping tasks in
kops get assets; but thismeant we would not discover assets for skipped tasks.
We are doing a dry-run here, so introduce a dry-run mode that
does not look for existing resources. That is essentially as fast
as skipping the task, but means we visit all tasks.