Skip to content

azure: Fix small issues related to role assignments #17478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

azure: Fix small issues related to role assignments #17478

merged 3 commits into from
Jul 9, 2025

Conversation

@hakman
Copy link
Member

@hakman hakman commented Jul 9, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2025
@hakman hakman changed the title azure: Fix small nits related to role assignments azure: Fix small issues related to role assignments Jul 9, 2025
@hakman
Copy link
Member Author

hakman commented Jul 9, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Jul 9, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2025
@ameukam
Copy link
Member

ameukam commented Jul 9, 2025

/test pull-kops-e2e-k8s-aws-amazonvpc

@hakman
Copy link
Member Author

hakman commented Jul 9, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Jul 9, 2025

/test all

@hakman
Copy link
Member Author

hakman commented Jul 9, 2025

/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 9, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 06b3e84 into kubernetes:master Jul 9, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jul 9, 2025
@hakman hakman mentioned this pull request Jul 11, 2025
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 11, 2025
@k8s-ci-robot
Merge pull request #17487 from hakman/automated-cherry-pick-of-#17478-#…
6ef7c6e 
…17483-upstream-release-1.33

Automated cherry pick of #17478: Fix role assignment for cluster resource group
#17483: azure: Deploy cloud-node-manager for K8s 1.31+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @k8s-ci-robot @ameukam