Skip to content

Conversation

@ameukam
Copy link
Member

@ameukam ameukam commented Aug 15, 2025

bumping golangci-lint to a version that support Go 1.25

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2025
@ameukam ameukam marked this pull request as ready for review August 15, 2025 11:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
@ameukam ameukam force-pushed the bump-golangci-lint branch from ab234e7 to 402e1ce Compare August 15, 2025 13:01
@ameukam ameukam force-pushed the bump-golangci-lint branch from 402e1ce to 338560a Compare August 22, 2025 19:42
@ameukam ameukam force-pushed the bump-golangci-lint branch from 338560a to 53bc622 Compare August 23, 2025 10:22
.golangci.yaml Outdated
staticcheck:
checks:
- all
- -SA1019
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the description of each of these as comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

bumping golangci-lint to a version that support Go 1.25

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the bump-golangci-lint branch from 53bc622 to 60895f5 Compare August 24, 2025 13:46
@hakman
Copy link
Member

hakman commented Aug 24, 2025

Thanks @ameukam!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2374797 into kubernetes:master Aug 24, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants