-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Restore default SELinux security contexts for containerd binaries #17633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/hold for comments |
nodeup/pkg/model/containerd.go
Outdated
|
|
||
| // Restore the default SELinux security contexts for the containerd and runc binaries | ||
| if b.Distribution.IsRHELFamily() && b.NodeupConfig.ContainerdConfig != nil && b.NodeupConfig.ContainerdConfig.SeLinuxEnabled { | ||
| manifest.Set("Service", "ExecStartPre", "/bin/sh -c 'restorecon -v /usr/bin/runc'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least on RHEL 9 with runc downloaded by kops:
| manifest.Set("Service", "ExecStartPre", "/bin/sh -c 'restorecon -v /usr/bin/runc'") | |
| manifest.Set("Service", "ExecStartPre", "/bin/sh -c 'restorecon -v /usr/sbin/runc'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, updated.
Signed-off-by: Ciprian Hacman <[email protected]>
|
/lgtm
|
|
Thanks for checking @jsafrane! 🙂 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on #9584 which was removed together with Docker support.
Alternative to #17579.
Fixes kubernetes/kubernetes#133484.
/cc @jsafrane @ameukam