-
Notifications
You must be signed in to change notification settings - Fork 735
Description
kubeadm currently has some matching configuration formats for its main commands.
join - JoinConfiguration
init - InitConfiguration
upgrade - none
reset - none
we should eventually provide API types for all main commands to avoid flags.
note this was not discussed as part of v1beta3, so it can happen in a future API version.
these are added in v1beta4
upgrade
upgrade does not have a config, forcing users to rely on flags only and forcing us as maintainers to have some flags unique to "upgrade" only.
we should add a scoped UpgradeConfiguration structure that can hold a number of relevant options to upgrade.
--config for upgrade should accept this configuration and not ClusterConfiguration | InitConfiguration...
maybe CC too:
#1681
- kubeadm: implementation of
UpgradeConfigurationAPI types kubernetes#114062 - kubeadm: implementation of UpgradeConfiguration API types kubernetes#123068
reset
this makes sense for consistency with respect to skipPhases. one other option is --force.
overall the structure for reset would be very minimal since it does not have a lot of options.