Skip to content

Graduate OpenAPI Enums to beta #108898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

Graduate OpenAPI Enums to beta #108898

merged 2 commits into from
Mar 25, 2022

Conversation

@jiahuif
Copy link
Contributor

@jiahuif jiahuif commented Mar 22, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR sets the feature gate OpenAPIEnums to beta.

We have searched and fixed/worked around types that cannot be marked as enum in #108639 this feature should be good to graduate.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

OpenAPI definitions served by kube-api-server now include enum types by default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2022
@jiahuif jiahuif force-pushed the feature/openapi-enums/to-beta branch from ab87568 to 77ff875 Compare March 22, 2022 23:38
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from deads2k and liggitt March 22, 2022 23:38
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2022
@jiahuif jiahuif force-pushed the feature/openapi-enums/to-beta branch 2 times, most recently from fb300ac to 3b8a969 Compare March 22, 2022 23:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2022
@jiahuif jiahuif force-pushed the feature/openapi-enums/to-beta branch 2 times, most recently from 642d32a to f8c4172 Compare March 23, 2022 21:05
@fedebongio
Copy link
Contributor

/assign @kubernetes/api-reviewers
/triage accepted

@fedebongio
Copy link
Contributor

/remove-triage accepted

@fedebongio
Copy link
Contributor

/triage accepted

1 similar comment
@jiahuif
Copy link
Contributor Author

jiahuif commented Mar 24, 2022

/triage accepted

@jiahuif
Copy link
Contributor Author

jiahuif commented Mar 24, 2022

/assign @apelisse

@jiahuif jiahuif force-pushed the feature/openapi-enums/to-beta branch from f8c4172 to 1f493f6 Compare March 24, 2022 18:00
@jiahuif
Copy link
Contributor Author

jiahuif commented Mar 24, 2022

/retest

@apelisse
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@jiahuif
Copy link
Contributor Author

jiahuif commented Mar 24, 2022

/assign @liggitt
Could you take a look too? Thank you.

@liggitt
Copy link
Member

liggitt commented Mar 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, jiahuif, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8f12e4a into kubernetes:master Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 25, 2022
@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2022

Please propose an update to the docs website.

@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Mar 27, 2022
Open
15 tasks
@tengqm tengqm mentioned this pull request Mar 29, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 29, 2022
Open
@cici37
Copy link
Contributor

cici37 commented Mar 29, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2022
@jiahuif jiahuif deleted the feature/openapi-enums/to-beta branch October 19, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@apelisse apelisse

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.24

Development

Successfully merging this pull request may close these issues.

7 participants

@jiahuif @fedebongio @apelisse @liggitt @k8s-ci-robot @tengqm @cici37