Skip to content

Remove ability to re-enable serving deprecated policyv1beta1 APIs #117666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Remove ability to re-enable serving deprecated policyv1beta1 APIs #117666

merged 1 commit into from
Jul 18, 2023

Conversation

@carlory
Copy link
Member

@carlory carlory commented Apr 28, 2023 •
edited by liggitt
Loading

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

Removes ability to re-enable serving deprecated policyv1beta1 types

FYI: https://kubernetes.io/docs/reference/using-api/#api-versioning

Which issue(s) this PR fixes:

ref #117659

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 28, 2023
@carlory carlory mentioned this pull request Apr 28, 2023
Closed
8 tasks
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot requested review from deads2k and liggitt April 28, 2023 06:43
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@carlory
Copy link
Member Author

carlory commented Apr 28, 2023

/test pull-kubernetes-integration

1 similar comment
@carlory
Copy link
Member Author

carlory commented Apr 28, 2023

/test pull-kubernetes-integration

@liggitt
Copy link
Member

liggitt commented Apr 28, 2023

removal of serving lgtm, integration test failures are related. some of those are testing compatibility with v1beta1 data, which we can still encounter reading from etcd.

@carlory carlory force-pushed the fix-008 branch 2 times, most recently from 3bc5cf3 to 91e1fd9 Compare April 29, 2023 13:24
@carlory
Copy link
Member Author

carlory commented Apr 29, 2023

/retest-required

liggitt
liggitt reviewed Apr 29, 2023
View reviewed changes
liggitt
liggitt reviewed Apr 29, 2023
View reviewed changes
@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 2, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 5, 2023
@carlory
Copy link
Member Author

carlory commented Jun 7, 2023

/cc @liggitt @deads2k

@nilekhc
Copy link
Contributor

nilekhc commented Jun 19, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 19, 2023
@carlory
Copy link
Member Author

carlory commented Jul 3, 2023

It's ready for review. Could you take a look? @liggitt @deads2k

liggitt
liggitt reviewed Jul 12, 2023
View reviewed changes
test/integration/disruption/disruption_test.go Outdated
Comment on lines 522 to 523
val, _ := json.Marshal(betaPDB)
_, err := etcdClient.Put(ctx, key, string(val))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match actual API server behavior, this should marshal to protobuf to persist in etcd, not json.

something like this could work:

protoSerializer := protobuf.NewSerializer(legacyscheme.Scheme, legacyscheme.Scheme)
buffer := bytes.NewBuffer()
if err := protoSerializer.Encode(betaPDB, buffer); err != nil {
  return err
}
... etcdClient.Put(ctx, key, string(buffer.String()))

@carlory carlory force-pushed the fix-008 branch 2 times, most recently from a1c2cf6 to c8f4cf0 Compare July 17, 2023 02:25
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 17, 2023
@carlory
Copy link
Member Author

carlory commented Jul 17, 2023

/test pull-kubernetes-unit

@carlory
Copy link
Member Author

carlory commented Jul 17, 2023

@liggitt I pushed some changes, please review again.

liggitt
liggitt reviewed Jul 17, 2023
View reviewed changes
@carlory
Copy link
Member Author

carlory commented Jul 18, 2023

/test pull-kubernetes-e2e-kind-ipv6

@liggitt
Copy link
Member

liggitt commented Jul 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b539854f046d1e9cea00275010d553f4c3395a61

@carlory
Copy link
Member Author

carlory commented Jul 18, 2023

@deads2k it's ready for review. can you take a quick look?

@liggitt
Copy link
Member

liggitt commented Jul 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56b59c8 into kubernetes:master Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 18, 2023
@sftim
Copy link
Contributor

sftim commented Jul 19, 2023

Is this change right?
https://kubernetes.io/docs/reference/using-api/deprecation-guide/ doesn;t list a removal for v1.28

Even if it's a bug fix, we might need to update that deprecation guide to clarify what happened.

@carlory
Copy link
Member Author

carlory commented Jul 19, 2023

@sftim sorry, I forgot to update doc. I will raise a website pr to fix later.

@liggitt
Copy link
Member

liggitt commented Jul 19, 2023 •
edited
Loading

Is this change right? https://kubernetes.io/docs/reference/using-api/deprecation-guide/ doesn;t list a removal for v1.28

This is cleaning up dead code that was already disabled and announced as removed in 1.25 (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125)

This change is not user-facing, so I dropped the release note

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Auth
Archived in project

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

8 participants

@carlory @k8s-triage-robot @liggitt @cici37 @nilekhc @k8s-ci-robot @sftim @deads2k