-
Notifications
You must be signed in to change notification settings - Fork 41.7k
KEP-4008: CRDValidationRatcheting: Add Benchmarks #121405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4008: CRDValidationRatcheting: Add Benchmarks #121405
Conversation
staging/src/k8s.io/apiextensions-apiserver/test/integration/ratcheting_test.go
Outdated
Show resolved
Hide resolved
|
/triage accepted |
46df451 to
c0bdff4
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 0b8ed37d309995b03fde36017a298588d7e59ac0
|
c0bdff4 to
3bfe568
Compare
jpbetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Noticed a minor typo, not blocking on it, but happy to retag if it gets fixed.
staging/src/k8s.io/apiextensions-apiserver/test/integration/ratcheting_test.go
Outdated
Show resolved
Hide resolved
|
LGTM label has been added. Git tree hash: 640639351dc5d54c9504cbaca2f4b9457c943343
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, apelisse, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3bfe568 to
bc1bc01
Compare
bc1bc01 to
8c72be3
Compare
|
/retest |
|
/lgtm |
|
LGTM label has been added. Git tree hash: ab26df1982fd57163c9f837b724c3c3a87c9b3b8
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Adds benchmarks of validation of Gateway API CRDs with and without ratcheting. Gateway API was chosen due to its extensive usage of CRD schema validations and CEL validiations.
To benchmark ratcheting we test ValidateUpdate(new, old) for the following sets of pairs of new and old:
On my system the difference is minimal (and may be reduced further by #121343
Special notes for your reviewer:
Based on #121016
/assign @apelisse
/sig api-machinery
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: