-
Notifications
You must be signed in to change notification settings - Fork 41.7k
Mark spec.selector as required in ReplicationController and add tests #135010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Mark spec.selector as required in ReplicationController and add tests #135010
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @priyansh3006. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: priyansh3006 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
and add corresponding declarative validation test cases.
3c61c9e to
665b950
Compare
|
I am considering migrating ReplicationControllerStatus's Components with +k8s:minimum=0 since they are manually checked for non-negative values. Should I include this in the current PR or open a separate one? |
|
/ok-to-test /cc @aaron-prindle @yongrulin @lalitc375 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
1.This change adds the +k8s:required tag to the spec.selector field in ReplicationController and includes validation tests to ensure an empty selector fails and a valid selector passes.
2. This change adds the +k8s:required tag to the template field in ReplicationControllerSpec to enforce its mandatory status in the API schema and includes corresponding validation tests for both nil (failure) and valid (success) scenarios.
Which issue(s) this PR is related to:
part of #134280
Special notes for your reviewer:
Code generation , Declarative Validation and fuzz testing are already enabled for ReplicationController as it is part of the core API group (group="", version="v1"), which is already registered
Does this PR introduce a user-facing change?
No
Additional documentation, e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[KEP]:
https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md