minikube fails to parse http_proxy with - in the address

[Menion2k]

What Happened?

Hi all

I am behind a corporate proxy which address is: internet-app.corp.thales:8000
minikube fails to properly parse the variable to set in the minikube container:

  **- HTTP_PROXY=http://AN006498:*****@internet**
! You appear to be using a proxy, but your NO_PROXY environment does not include the minikube IP (192.168.49.2).
* Please see https://minikube.sigs.k8s.io/docs/handbook/vpn_and_proxy/ for more details
  - HTTPS_PROXY=http://AN006498:*****@internet
  - NO_PROXY=localhost,********
**! Failing to connect to https://registry.k8s.io/ from inside the minikube container**

As you can see the http_proxy is stopped at the -. I tried to set the - with ascii escape but:

! Error parsing HTTPS_PROXY=http://AN006498:*********@internet%2dapp.corp.thales:8000, parse "http://AN006498:*********@internet%2dapp.corp.thales:8000": invalid URL escape "%2d"

I tried to set an proxy hostname in the system, but of course the certificate is invalid due to different FQDN and minikube still fails to connect upstream for updating the container contents.

kubernetes environment seems to be ok:

* Preparing Kubernetes v1.32.0 on Docker 27.4.1 ...
  - env HTTP_PROXY=http://AN006498:********@internet-app.corp.thales:8000
  - env HTTPS_PROXY=http://AN006498:*********@internet-app.corp.thales:8000
  - env NO_PROXY=localhost,***********
  - Generating certificates and keys ...

Attach the log file

no logs to be provided

Operating System

Ubuntu

Driver

Docker

[medyagh]

hi @Menion2k that does seem to be a bug, would you be interested to make a PR to fix it ?
I suspsect the source of the issue be this code

https://github.com/medyagh/minikube/blob/e50295f15bdd0a5b5853f69011d1d01a70e6fade/pkg/util/utils.go#L130

[medyagh]

@CalobTech I see you work on a PR that touches proxy, can you confirm that this is happening ?

[medyagh]

@rmsilva1973 do you mind taking a look at this ? could masking the password in this PR #17116 be source of the issue ?
rmsilva1973

[Menion2k]

hi @Menion2k that does seem to be a bug, would you be interested to make a PR to fix it ? I suspsect the source of the issue be this code

https://github.com/medyagh/minikube/blob/e50295f15bdd0a5b5853f69011d1d01a70e6fade/pkg/util/utils.go#L130

Can definitely be that the issue, the way the address is handled by the regular expression

[medyagh]

we should add a unit test and make sure to add this as a test case

[rmsilva1973]

@medyagh as far as I remeber, it was masking only the output. But let me pull the repo and take a look here.

edit: The MaskProxyPassword is only used to output the (masked) proxy variables indeed. Minikube retrieves the untainted proxy string with os.GetEnv("HTTPS_PROXY")

Even though, I can create a PR to fix the broken output. I have to create an issue first as the masking function doesn't seem to be the cause for this particular issue as far as I can tell.

[medyagh]

@rmsilva1973 @Menion2k
here is the link to the binary from a PR that I think might fix this issue, do you mind trying it out ?

https://storage.googleapis.com/minikube-builds/20648/minikube-linux-amd64
https://storage.googleapis.com/minikube-builds/20648/minikube-darwin-amd64
https://storage.googleapis.com/minikube-builds/20648/minikube-windows-amd64.exe

#20648