Remove WSLENV empty check from IsMicrosoftWSL

[spowelljr]

Closes #10689

Removed WSLENV empty check from IsMicrosoftWSL due to Windows Terminal setting the variable outside of WSL.

#10711 (comment)

We have code that tries to detect if we're trying to run a Windows executable within a WSL shell, which should be running a Linux binary. The most reliable way to do that is to check environment variables that WSL sets. Unfortunately, one of the 3 variables we picked (WSLENV) is set by Windows Terminal, outside of WSL, as a way of carrying data across connections. This is causing some Windows users to not be able to use minikube in a valid config.

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

Closes #10689

Removed WSLENV empty check from IsMicrosoftWSL due to Windows Terminal setting the variable outside of WSL.

Could you add more detail to the PR description?

I don't quite understand the problem that is being solved, and why this is the best approach to fix it.

[sharifelgamal]

We have code that tries to detect if we're trying to run a Windows executable within a WSL shell, which should be running a Linux binary. The most reliable way to do that is to check environment variables that WSL sets. Unfortunately, one of the 3 variables we picked (WSLENV) can be set in Powershell, outside of WSL, as a way of carrying data across connections. This is causing some Windows users to not be able to use minikube in a valid config.

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10711): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10711/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10711/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10711): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10711/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10711/minikube: exec format error

[ghost]

Just built this for Windows and can confirm this fixes the issue.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NatsumiHB, spowelljr
To complete the pull request process, please assign medyagh after the PR has been reviewed.
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment