Skip to content

Fix to minikube cp functional test work on windows os #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Fix to minikube cp functional test work on windows os #10920

merged 1 commit into from
Mar 29, 2021

Conversation

@anencore94
Copy link
Contributor

@anencore94 anencore94 commented Mar 25, 2021 •
edited
Loading

Bug from PR #10198

resolve : #10914

Thanks for finding it @medyagh

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2021

Hi @anencore94. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anencore94
To complete the pull request process, please assign afbjorklund after the PR has been reviewed.
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2021
@minikube-bot
Copy link
Collaborator

minikube-bot commented Mar 25, 2021

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Mar 25, 2021

@anencore94
Checkout the setup certes in the functional. Test to see an example

@medyagh
Copy link
Member

medyagh commented Mar 25, 2021

Checkout other tests copying files

func setupFileSync(ctx context.Context, t *testing.T, profile string) {
	p := localSyncTestPath
...

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021
@anencore94 anencore94 force-pushed the cp_window branch 3 times, most recently from 5819d5d to dd98a90 Compare March 25, 2021 08:31
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2021
@anencore94 anencore94 force-pushed the cp_window branch 2 times, most recently from ee057b6 to ea9727b Compare March 26, 2021 06:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2021
Fix to minikube cp functional test work on windows os
4f9aac3 
- use filpath lib to represent local path depends on host os
- write within-minikube-path as function to represent what
 the path means
@anencore94
Copy link
Contributor Author

anencore94 commented Mar 26, 2021

Changed List

  • make test code more understandable like func setupFileSync(ctx context.Context, t *testing.T, profile string) {...}
  • change filepath.IsAbs() to strings.HasPrefix().
    • since on windows host os, filepath.IsAbs('/a/b/c') equals false
    • I'm a bit confused why this happens..

Please Let me know if there are other issues.
Thanks a lot always, @medyagh

@anencore94 anencore94 changed the title [WIP] Fix to minikube cp functional test work on windows os Fix to minikube cp functional test work on windows os Mar 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
medyagh
medyagh requested changes Mar 29, 2021
View reviewed changes
test/integration/functional_test.go
cpPath := filepath.Join(*testdataDir, "cp-test.txt")
rr, err := Run(t, exec.CommandContext(ctx, Target(), "-p", profile, "cp", cpPath, "/home/docker/hello_cp.txt"))
srcPath := cpTestLocalPath()
dstPath := cpTestMinikubePath()
Copy link
Member

@medyagh medyagh Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not make a func for that, and just simply put it here, easier to read

@medyagh medyagh merged commit 29f0aec into kubernetes:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@medyagh medyagh medyagh requested changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestFunctional/parallel/CpCmd failing on Windows: cat: /home/docker/hello_cp.txt: No such file or directory

4 participants

@anencore94 @k8s-ci-robot @minikube-bot @medyagh