Thank PR reviewers and issue-commenters in hack/release_notes.sh. #11277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10671.
Before:
After:
Note pullsheet throws off lots of logs to stderr, so piping error output to /dev/null is very useful.
Unfortunately, it is difficult to get names of users (although in practice this can likely be done manually by copying from the contributor list). This is due to the fact that GitHub does not track names of users very well, even though a user's git commits do contain their name for the most part - so even modifying pullsheet directly to pass names would not work.
A possible mitigation to this is to have pullsheet return one random commit from each reviewer and then lookup those in git to extract their names although this is way more complicated and will break if a reviewer has never had a PR merged. Assembling the release notes is a manual process anyway, so usernames will likely be fine.