Skip to content

bug: return error on invalid function name in extract.TranslatableStrings #11454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

bug: return error on invalid function name in extract.TranslatableStrings #11454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/extract/extract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func newExtractor(functionsToCheck []string) (*state, error) {
// Functions must be of the form "package.function"
t2 := strings.Split(t, ".")
if len(t2) < 2 {
return nil, errors.Wrap(nil, fmt.Sprintf("Invalid function string %s. Needs package name as well.", t))
return nil, errors.Errorf("invalid function string %s. Needs package name as well", t)
}
f := funcType{
pack: t2[0],
Expand Down
10 changes: 10 additions & 0 deletions pkg/minikube/extract/extract_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package extract

import (
"encoding/json"
"errors"
"io/ioutil"
"os"
"path/filepath"
Expand Down Expand Up @@ -84,3 +85,12 @@ func TestExtract(t *testing.T) {
}

}

func TestExtractShouldReturnErrorOnFunctionWithoutPackage(t *testing.T) {
expected := errors.New("Initializing: invalid function string missing_package. Needs package name as well")
funcs := []string{"missing_package"}
err := TranslatableStrings([]string{}, funcs, "")
if err == nil || err.Error() != expected.Error() {
t.Fatalf("expected %v, got %v", expected, err)
}
}