Skip to content

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Jun 1, 2021

for some corps/enterprise users it doesn't work when we try to pull image with SHA we should try at least to pull wihtout sha before failing
#11068

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@medyagh
Copy link
Member Author

medyagh commented Jun 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 1, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11559) |
+----------------+----------+---------------------+
| minikube start | 47.0s    | 47.2s               |
| enable ingress | 38.2s    | 37.7s               |
+----------------+----------+---------------------+

Times for minikube start: 48.0s 46.6s 46.5s 47.3s 46.9s
Times for minikube (PR 11559) start: 46.7s 48.5s 45.7s 47.4s 47.9s

Times for minikube ingress: 42.2s 34.2s 36.7s 34.2s 43.7s
Times for minikube (PR 11559) ingress: 34.3s 41.7s 34.7s 42.2s 35.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11559) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 21.6s               |
| enable ingress | 36.0s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 20.7s 21.1s 21.6s 20.8s
Times for minikube (PR 11559) start: 21.5s 21.3s 21.8s 22.2s 21.3s

Times for minikube ingress: 37.5s 41.5s 32.0s 32.5s 36.5s
Times for minikube (PR 11559) ingress: 34.0s 32.5s 35.0s 34.5s 37.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11559) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 47.1s 46.8s 44.2s 43.1s
Times for minikube (PR 11559) start: 42.8s 47.2s 43.2s 43.2s 47.1s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 1b0e6f1 into kubernetes:master Jun 2, 2021
@medyagh medyagh deleted the img_sha branch May 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants