Skip to content

Disallow using Docker Desktop 4.34.0 on macos #19576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Disallow using Docker Desktop 4.34.0 on macos #19576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2955b9
Disallow using Docker Desktop 4.34.0 on macos
medyagh Sep 6, 2024
7027336
Disallow using Docker Desktop 4.34.0 on macos
medyagh Sep 6, 2024
a47f15b
remove unneeded changes
medyagh Sep 6, 2024
fdb26cf
remove unneeded changes
medyagh Sep 6, 2024
2e9b50a
update changelog
medyagh Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Breaking Changes:
* Bump minimum podman version to 4.9.0 [#19457](https://github.com/kubernetes/minikube/pull/19457)

* Disallow using Docker Desktop 4.34.0
Features:
* Bump default Kubernetes version to v1.31.0 [#19435](https://github.com/kubernetes/minikube/pull/19435)
* Add new driver for macOS: vfkit [#19423](https://github.com/kubernetes/minikube/pull/19423)
Expand Down
11 changes: 11 additions & 0 deletions pkg/minikube/registry/drvs/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,17 @@ func checkDockerDesktopVersion(version string) (s registry.State) {
Fix: "Update Docker Desktop to 4.16.1 or greater",
}
}

if runtime.GOOS == "darwin" && currSemver.EQ(semver.MustParse("4.34.0")) {
return registry.State{
Reason: "PROVIDER_DOCKER_DESKTOP_VERSION_BAD",
Running: true,
Error: errors.New("Docker Desktop 4.34.0 has a regression that prevents minikube from listing the containers"),
Installed: true,
Fix: "Use a different Docker desktop version, more info at https://github.com/docker/cli/issues/5412",
}
}

return s
}

Expand Down