Skip to content

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented Nov 22, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2024
@medyagh
Copy link
Member Author

medyagh commented Nov 22, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19985) |
+----------------+----------+---------------------+
| minikube start | 47.9s    | 47.8s               |
| enable ingress | 16.7s    | 16.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 19985) start: 45.5s 48.9s 48.9s 46.7s 49.1s
Times for minikube start: 48.8s 45.9s 48.9s 47.0s 48.7s

Times for minikube ingress: 15.0s 18.5s 16.0s 19.0s 15.0s
Times for minikube (PR 19985) ingress: 15.0s 18.4s 15.5s 19.0s 15.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19985) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 21.1s               |
| enable ingress | 13.3s    | 14.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.3s 23.7s 24.0s 20.7s 23.9s
Times for minikube (PR 19985) start: 20.3s 23.5s 20.7s 20.4s 20.8s

Times for minikube ingress: 13.8s 13.3s 12.8s 12.8s 13.8s
Times for minikube (PR 19985) ingress: 16.3s 13.3s 13.3s 13.3s 13.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19985) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.2s               |
| enable ingress | 39.6s    | 36.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 40.3s 39.3s 39.2s 39.8s 39.2s
Times for minikube (PR 19985) ingress: 39.2s 38.8s 27.3s 38.8s 38.8s

Times for minikube start: 22.0s 22.3s 20.2s 19.9s 23.0s
Times for minikube (PR 19985) start: 19.2s 20.4s 22.4s 22.9s 21.0s

@medyagh medyagh merged commit 2b52e11 into kubernetes:master Dec 4, 2024
23 of 37 checks passed
@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants