Add Members 2022-08-18 #3620
Merged
Add Members 2022-08-18 #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
This was referenced Aug 17, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, savitharaghunathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@palnabarun I see there is a hold for pending requests. is #3617 a part of pending request? |
9 tasks
|
@savitharaghunathan -- I was waiting for the remaining +1 on #3619. We are good to remove the hold now. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Oops. The PR merged before the last force push. |
|
I am raising another PR to fix the error. |
|
@palnabarun I was just going to reach out to you about that :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3595
fixes #3599
fixes #3609
fixes #3610
fixes #3615
fixes #3616
fixes #3617
fixes #3619
/area github-membership
/hold for a few more requests