Skip to content

Reorganize storage tests #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2019
Merged

Reorganize storage tests #688

merged 2 commits into from
Jul 25, 2019

Conversation

@hantaowang
Copy link

@hantaowang hantaowang commented Jul 25, 2019 •
edited
Loading

This PR reorganizes the storage tests so there is no distinction between ephemeral and persistent storage types. It also combines the test config for 1 node and multi node tests, which was largely repeated.

@wojtek-t @davidz627 @jingxu97 @mucahitkurt

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 25, 2019

Hi @hantaowang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2019
@k8s-ci-robot k8s-ci-robot requested review from mm4tt and wojtek-t July 25, 2019 01:21
@hantaowang
Copy link
Author

hantaowang commented Jul 25, 2019

/hold
because untested. I will test tomorrow.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2019
@hantaowang hantaowang mentioned this pull request Jul 25, 2019
Merged
@hantaowang hantaowang force-pushed the reorganize-storage-tests branch 2 times, most recently from 8530260 to d300b24 Compare July 25, 2019 04:31
@hantaowang
Copy link
Author

hantaowang commented Jul 25, 2019

/hold cancel
This has been tested.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2019
@hantaowang hantaowang force-pushed the reorganize-storage-tests branch from d300b24 to d623320 Compare July 25, 2019 04:42
wojtek-t
wojtek-t reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool - I like it.
I left just couple minor comments.

@mucahitkurt - FYI

...terloader2/testing/experimental/storage/pod-startup/tests/max_volumes_per_node/override.yaml
@@ -0,0 +1,3 @@
PODS_PER_NODE: 100
Copy link
Member

@wojtek-t wojtek-t Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the "tests/" directory (this whole directory clusterloader2/testing is only about tests).

clusterloader2/testing/experimental/storage/pod-startup/max_volumes_per_node/override.yaml

is enough

Copy link
Author

@hantaowang hantaowang Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, i thought it would be confusing if the tests are at the same level as the volume-types

...terloader2/testing/experimental/storage/pod-startup/tests/max_volumes_per_node/override.yaml Outdated
@@ -0,0 +1,3 @@
PODS_PER_NODE: 100
VOLUMES_PER_POD: 1
NODES_PER_NAMESPACE: 1 No newline at end of file
Copy link
Member

@wojtek-t wojtek-t Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add new lines at the end of files

Copy link
Member

@wojtek-t wojtek-t Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in other files you added.

clusterloader2/testing/experimental/storage/pod-startup/config.yaml
{{$PODS_PER_NODE := DefaultParam .PODS_PER_NODE 30}}

{{$POD_TEMPLATE_PATH := DefaultParam .POD_TEMPLATE_PATH "../emptydir/pod_with_emptydir.yaml"}}
{{$POD_TEMPLATE_PATH := DefaultParam .POD_TEMPLATE_PATH "../volume-types/emptydir/pod_with_emptydir.yaml"}}
Copy link
Member

@wojtek-t wojtek-t Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this PR is going to break all the existing tests that are running.
Given they are experimental I'm fine with breaking them for a moment, but you should prepare a PR in test-infra that will fix the paths to configs and overrides so that we can merge that immediately after this PR will be merged.

Copy link
Member

@wojtek-t wojtek-t Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With kubernetes/test-infra#13601 opened, I'm fine with approving this one.

@wojtek-t wojtek-t mentioned this pull request Jul 25, 2019
Merged
@hantaowang hantaowang force-pushed the reorganize-storage-tests branch from d623320 to 8c9e79d Compare July 25, 2019 07:58
@hantaowang hantaowang mentioned this pull request Jul 25, 2019
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Jul 25, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hantaowang, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 401eb14 into kubernetes:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hantaowang @k8s-ci-robot @wojtek-t