Skip to content

Conversation

@cpanato
Copy link
Member

@cpanato cpanato commented Mar 22, 2022

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • drop config for 1.20 branch
  • k8s-cloud-builder/k8s-ci-builder: build using Go 1.18

k/k prs is merged kubernetes/kubernetes#108870

Which issue(s) this PR fixes:

xref #2307

Does this PR introduce a user-facing change?

k8s-cloud-builder/k8s-ci-builder: build using Go 1.18 

/assign @saschagrunert @xmudrii @Verolop @puerco @dims
cc @kubernetes/release-engineering

@cpanato cpanato mentioned this pull request Mar 22, 2022
45 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2022
@cpanato
Copy link
Member Author

cpanato commented Mar 22, 2022

/assign @justaugustus

@dims
Copy link
Member

dims commented Mar 22, 2022

LGTM, will let rel-eng members do the honors :)

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's party!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fa544b8 into kubernetes:master Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 22, 2022
@cpanato cpanato deleted the go-118 branch March 23, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants