Skip to content

Conversation

@roycaihw
Copy link
Member

@roycaihw roycaihw commented Mar 5, 2019

to pull-kubernetes-e2e-gce-alpha-features and ci-kubernetes-e2e-gci-gce-alpha-features

/cc @mbohlool @sttts

it's reasonable that alpha feature should be non-blocking (they should not be part of pull-kubernetes-e2e-gce); but it's not obvious that people have to update test-infra to include their tests in non-blocking jobs such as pull-kubernetes-e2e-gce-alpha-features and ci-kubernetes-e2e-gci-gce-alpha-features. As a result CustomResourceWebhookConversion tests were skipped.

nit: I'd expect the test_args to be --ginkgo.focus=\[Feature:.+\]

Tests:

@k8s-ci-robot k8s-ci-robot requested review from mbohlool and sttts March 5, 2019 01:34
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2019
@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2019

/approve

punt reviewers to lgtm
also cc @amwat @spiffxp

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@sttts
Copy link
Contributor

sttts commented Mar 5, 2019

Lgtm from api-machinery point of view. But have no clue what this means for testing.

@roycaihw
Copy link
Member Author

roycaihw commented Mar 5, 2019

my understanding is that we don't enable new [Feature:XXX] tests in CI / (non-)blocking presubmit by default. this is to make the tests run in

non-blocking presubmit: https://testgrid.k8s.io/presubmits-kubernetes-nonblocking#pull-kubernetes-e2e-gce-alpha-features
and
CI: https://testgrid.k8s.io/google-gce#gci-gce-alpha-features

(although pull-kubernetes-e2e-gce-alpha-features has been stale since 3/2)
@krzyzacy pointed out that pull-kubernetes-e2e-gce-alpha-features is not a always run job so you need to /test job-name to run it

@roycaihw
Copy link
Member Author

roycaihw commented Mar 5, 2019

manually triggered pull-kubernetes-e2e-gce-alpha-features in kubernetes/kubernetes#71192

the [Feature:CustomResourcePublishOpenAPI] tests were skipped https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71192/pull-kubernetes-e2e-gce-alpha-features/123

@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2019

technically you can make the presubmit job change and merge that, and make sure it can pass your PR, and then update the periodic job.

test to pull-kubernetes-e2e-gce-alpha-features
@roycaihw roycaihw force-pushed the add-crd-alpha-feature-tests branch from 6b019d8 to 800b794 Compare March 5, 2019 21:23
@roycaihw
Copy link
Member Author

roycaihw commented Mar 5, 2019

technically you can make the presubmit job change and merge that, and make sure it can pass your PR, and then update the periodic job

that sounds good. I withdrew the periodic job change. @krzyzacy could you tag this PR?

@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 030a5968ac0274fc5a9cbdb05427c6846ee2cd78

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2019

/test pull-test-infra-verify-govet

@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2019

go: golang.org/x/[email protected]: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/prow/go/pkg/mod/cache/vcs/de5fd3af413a4f3f969455ae522b4002fcb7bb4c158f339396dfc77710c9007d: exit status 128:
fatal: git fetch-pack: expected ACK/NAK, got '�error: Access denied to IP 35.202.47.97'
fatal: The remote end hung up unexpectedly
go: golang.org/x/[email protected]: unknown revision 0c41d7ab0a0e
go: golang.org/x/[email protected]: unknown revision 8ac0e0d97ce4

/shrug
/retest

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit dca889a into kubernetes:master Mar 5, 2019
@k8s-ci-robot
Copy link
Contributor

@roycaihw: Updated the job-config configmap in namespace default using the following files:

  • key generated-security-jobs.yaml using file config/jobs/kubernetes-security/generated-security-jobs.yaml
  • key sig-gcp-gce-config.yaml using file config/jobs/kubernetes/sig-gcp/sig-gcp-gce-config.yaml

In response to this:

to pull-kubernetes-e2e-gce-alpha-features and ci-kubernetes-e2e-gci-gce-alpha-features

/cc @mbohlool @sttts

it's reasonable that alpha feature should be non-blocking (they should not be part of pull-kubernetes-e2e-gce); but it's not obvious that people have to update test-infra to include their tests in non-blocking jobs such as pull-kubernetes-e2e-gce-alpha-features and ci-kubernetes-e2e-gci-gce-alpha-features. As a result CustomResourceWebhookConversion tests were skipped.

nit: I'd expect the test_args to be --ginkgo.focus=\[Feature:.+\]

Tests:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants