-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add CRD-related alpha feature tests #11618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRD-related alpha feature tests #11618
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Lgtm from api-machinery point of view. But have no clue what this means for testing. |
|
my understanding is that we don't enable new [Feature:XXX] tests in CI / (non-)blocking presubmit by default. this is to make the tests run in non-blocking presubmit: https://testgrid.k8s.io/presubmits-kubernetes-nonblocking#pull-kubernetes-e2e-gce-alpha-features
|
|
manually triggered the |
|
technically you can make the presubmit job change and merge that, and make sure it can pass your PR, and then update the periodic job. |
test to pull-kubernetes-e2e-gce-alpha-features
6b019d8 to
800b794
Compare
that sounds good. I withdrew the periodic job change. @krzyzacy could you tag this PR? |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 030a5968ac0274fc5a9cbdb05427c6846ee2cd78
|
|
/test pull-test-infra-verify-govet |
/shrug |
|
@roycaihw: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
to
pull-kubernetes-e2e-gce-alpha-featuresandci-kubernetes-e2e-gci-gce-alpha-features/cc @mbohlool @sttts
it's reasonable that alpha feature should be non-blocking (they should not be part of
pull-kubernetes-e2e-gce); but it's not obvious that people have to update test-infra to include their tests in non-blocking jobs such aspull-kubernetes-e2e-gce-alpha-featuresandci-kubernetes-e2e-gci-gce-alpha-features. As a resultCustomResourceWebhookConversiontests were skipped.nit: I'd expect the test_args to be
--ginkgo.focus=\[Feature:.+\]Tests: