Skip to content

Update kubekins-e2e to Go 1.21.0 and drop config for k8s 1.24 #30631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2023
Merged

Update kubekins-e2e to Go 1.21.0 and drop config for k8s 1.24 #30631

merged 1 commit into from
Sep 6, 2023

Conversation

@cpanato
Copy link
Member

@cpanato cpanato commented Sep 6, 2023

  • Update kubekins-e2e to Go 1.21.0 and drop config for k8s 1.24

xref: kubernetes/release#3076

/assign @saschagrunert @aojea @Verolop
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2023
@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

/assign @BenTheElder

@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
xmudrii
xmudrii approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@cpanato cpanato mentioned this pull request Sep 6, 2023
Closed
36 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Sep 6, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79f4b86 into kubernetes:master Sep 6, 2023
@cpanato cpanato deleted the update-kubekins branch September 7, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

+1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@Verolop Verolop

@aojea aojea

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cpanato @k8s-ci-robot @saschagrunert @xmudrii @BenTheElder @Verolop @aojea