Skip to content

Conversation

@Rishit-dagli
Copy link
Contributor

@Rishit-dagli Rishit-dagli commented Jun 13, 2022

Removes Katacoda warning at the moment which could be reinstated as discussed in #34255

Fixes #34255

/sig docs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from daminisatya June 13, 2022 16:38
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm June 13, 2022 16:38
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 13, 2022
@netlify
Copy link

netlify bot commented Jun 13, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fc8c353
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62a7680b07703f0008144130
😎 Deploy Preview https://deploy-preview-34262--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jun 14, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46d3920af7167c53ff35343f3f4b8afc9395b7e2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@reylejano
Copy link
Member

/hold until after June 15 to test katacoda scenarios

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@sftim
Copy link
Contributor

sftim commented Jun 14, 2022

/approve

If we need this approved, I'm happy to. The hold still stands.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@sftim
Copy link
Contributor

sftim commented Jun 14, 2022

@reylejano could you clarify why you've held this PR? I'm not sure I understand your intent there.

@Rishit-dagli
Copy link
Contributor Author

@reylejano I believe the hold should now be removed

@sftim
Copy link
Contributor

sftim commented Jun 17, 2022

/hold cancel

We can use the code that we're removing in case of any different change to Katacoda that we might need to announce.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit b835209 into kubernetes:main Jun 17, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-katacoda-banner branch June 17, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Katacoda banner may be misleading.

5 participants