Skip to content

Conversation

@Rishit-dagli
Copy link
Contributor

Updates the Job tracking with the finalizers section under the Jobs page which is not enabled by default from 1.24 (kubernetes/kubernetes#109487)

Fixes #32944

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 19, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 19, 2022
@netlify
Copy link

netlify bot commented Jun 19, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c9015d2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62aeb8d312424e000a84dc69
😎 Deploy Preview https://deploy-preview-34397--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jun 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59d1794dc71b14694244de103dbb2ce59c067c1a

@Rishit-dagli
Copy link
Contributor Author

Rishit-dagli commented Jun 20, 2022

To complete the pull request process, please assign savitharaghunathan after the PR has been reviewed.

/assign @savitharaghunathan

@sftim
Copy link
Contributor

sftim commented Jun 20, 2022

Thanks
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 92d4bbf into kubernetes:main Jun 20, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-jobs branch June 20, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Jobs Page, Job tracking with finalizers section

5 participants