Skip to content

Conversation

@Rishit-dagli
Copy link
Contributor

Updates command in the "Connecting Applications with Services" page to only show the my-nginx podIp

Fixes #34389

Note: The way the output is documented, this still remains same
Co-authored-by: Eduardo Patrocinio <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 19, 2022
@netlify
Copy link

netlify bot commented Jun 19, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ee52f51
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6306f3b228df7b000810ada0
😎 Deploy Preview https://deploy-preview-34399--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rishit-dagli Rishit-dagli requested a review from tengqm June 19, 2022 09:25
@Rishit-dagli
Copy link
Contributor Author

/retitle Update command in "Connecting Applications with Services" and separate out a command

@k8s-ci-robot
Copy link
Contributor

@Rishit-dagli: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Update command in "Connecting Applications with Services" and separate out a command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rishit-dagli Rishit-dagli changed the title Update command in "Connecting Applications with Services" page Update command in "Connecting Applications with Services" and separate out a command Jun 20, 2022
@Rishit-dagli Rishit-dagli requested a review from sftim June 20, 2022 12:03
@sftim
Copy link
Contributor

sftim commented Jun 20, 2022

As it's your own PR, you can still use the GitHub web UI (or API, if you're feeling keen) to retitle. Try searching in the web page for “Edit”.

@Rishit-dagli
Copy link
Contributor Author

Yep, I retitled it using the UI a little while ago, I had never run \retitle so I just thought to try it 😆

@annajung
Copy link
Contributor

annajung commented Aug 8, 2022

I believe this is okay as is since grep issue is being addressed in a different pull request (#34457)

deploy preview: https://deploy-preview-34399--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/connect-applications-service/#securing-the-service

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c42a8df8c7bc53ad3fd24fc039b53c925048c88d

@Rishit-dagli
Copy link
Contributor Author

/assign @kcmartin

To complete the pull request process, please assign kcmartin after the PR has been reviewed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2022
@Rishit-dagli Rishit-dagli requested review from reylejano and removed request for annajung, caesarxuchao, kcmartin, lavalamp, sftim and tengqm August 25, 2022 03:59
@reylejano
Copy link
Member

Re-applying lgtm from this comment
/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a067f0d2b1abf8239f496287f4aa677e04572e95

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 640c963 into kubernetes:main Aug 26, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-securing-service branch August 26, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command in the "Connecting Applications with Services" page shows IP of multiple deployments

8 participants