Skip to content

Conversation

@Rishit-dagli
Copy link
Contributor

This PR is related to failing tests from #34387 , it seems that the ja docs depend on the glossary entry from the en docs

Please see #34387 (comment)

Note: we still need to make the changes to this file similar to: https://github.com/kubernetes/website/pull/34387/files#diff-c3ff1d9d7e9d80de144e2e81435a237bcf5ae030d68782cc602a9c471615038aL1-L18

/cc jihoon-seo

@k8s-ci-robot k8s-ci-robot requested a review from jihoon-seo June 21, 2022 08:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 21, 2022
@netlify
Copy link

netlify bot commented Jun 21, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fecaaf6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ba5b2ac30df70008cbe53b
😎 Deploy Preview https://deploy-preview-34439--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jun 24, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@tengqm
Copy link
Contributor

tengqm commented Jun 24, 2022

Looks like this one is blocking #34387, IIUC.

@jihoon-seo
Copy link
Member

jihoon-seo commented Jun 24, 2022

/hold
I think that it would be great if some Japanese reviewer check and confirm whether the Japanese string is okay,
since the word "Service Broker" is just fork-lifted from the original Japanese sentence.

[As-is]

サービスカタログを使用することでサービスブローカーが提供するマネージドサービスを、それらのサービスがどのように作成されるか、また管理されるかについての知識を無しに、一覧表示したり、プロビジョニングや使用をすることができます。

[English translation of "As-is" above]

List, provision, and use managed services provided by service brokers by using service catalogs without any knowledge of how those services are created and managed. can do.

[To-be]

サービスカタログを使用することでが提供するマネージドサービスを、それらのサービスがどのように作成されるか、また管理されるかについての知識を無しに、一覧表示したり、プロビジョニングや使用をすることができます。

[English translation of "To-be" above]

You can list, provision, and use managed services provided by using the Service Catalog without any knowledge of how those services are created and managed. I can do it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from reylejano June 24, 2022 02:13
@reylejano reylejano removed their assignment Jun 24, 2022
@reylejano
Copy link
Member

/assign @inductor

@reylejano reylejano removed their request for review June 24, 2022 02:14
@Rishit-dagli
Copy link
Contributor Author

I think that it would be great if some Japanese reviewer check and confirm whether the Japanese string is okay,
since the word "Service Broker" is just fork-lifted from the original Japanese sentence.

+1, I had also included this in the PR description. Right now this PR only fixes the build errors we run into if we merge #34387 however the other changes (like in the en PR) and verifying the sentence as a whole does require a ja volunteer

Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@jihoon-seo
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 24, 2022
@nasa9084
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a99c1998697400316e3f22367a6023a2fddb4c8

@Rishit-dagli
Copy link
Contributor Author

Rishit-dagli commented Jun 28, 2022

@jihoon-seo I believe the hold should now be removed

Edit: the commits have now been squashed

Update content/ja/docs/reference/glossary/service-catalog.md

Co-authored-by: nasa9084 <[email protected]>
@Rishit-dagli Rishit-dagli force-pushed the Rishit-dagli-ja-servicecatalog branch from 24d7327 to fecaaf6 Compare June 28, 2022 01:36
@jihoon-seo
Copy link
Member

@Rishit-dagli Okay let's move on!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7d02759 into kubernetes:main Jun 28, 2022
@Rishit-dagli Rishit-dagli deleted the Rishit-dagli-ja-servicecatalog branch June 28, 2022 02:45
snowcrystall pushed a commit to snowcrystall/website that referenced this pull request Jun 30, 2022
Update content/ja/docs/reference/glossary/service-catalog.md

Co-authored-by: nasa9084 <[email protected]>

Co-authored-by: nasa9084 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants