-
Couldn't load subscription status.
- Fork 15.1k
[ja] Remove Service Broker reference #34439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] Remove Service Broker reference #34439
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like this one is blocking #34387, IIUC. |
|
/hold [As-is]
[English translation of "As-is" above]
[To-be]
[English translation of "To-be" above]
|
|
/assign @inductor |
+1, I had also included this in the PR description. Right now this PR only fixes the build errors we run into if we merge #34387 however the other changes (like in the en PR) and verifying the sentence as a whole does require a ja volunteer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
|
/label tide/merge-method-squash |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6a99c1998697400316e3f22367a6023a2fddb4c8
|
|
@jihoon-seo I believe the hold should now be removed Edit: the commits have now been squashed |
Update content/ja/docs/reference/glossary/service-catalog.md Co-authored-by: nasa9084 <[email protected]>
24d7327 to
fecaaf6
Compare
|
@Rishit-dagli Okay let's move on! |
Update content/ja/docs/reference/glossary/service-catalog.md Co-authored-by: nasa9084 <[email protected]> Co-authored-by: nasa9084 <[email protected]>
This PR is related to failing tests from #34387 , it seems that the ja docs depend on the glossary entry from the
endocsPlease see #34387 (comment)
Note: we still need to make the changes to this file similar to: https://github.com/kubernetes/website/pull/34387/files#diff-c3ff1d9d7e9d80de144e2e81435a237bcf5ae030d68782cc602a9c471615038aL1-L18
/cc jihoon-seo