Skip to content

Conversation

@windsonsea
Copy link
Member

@windsonsea windsonsea commented Jun 22, 2022

The path is content/en/docs/tasks/job/automated-tasks-with-cron-jobs

Added tags to each title for easily referenced by other pages and other minor changes.

In this morning, a workmate asked me what is the correct spelling among CronJob, cron job, cronJob, and Cronjob. I answered him that it might be a good suggestion to follow the concept title of CronJob.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 22, 2022
@netlify
Copy link

netlify bot commented Jun 22, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3e51d19
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62b855519e0ab2000892a7b4
😎 Deploy Preview https://deploy-preview-34465--kubernetes-io-main-staging.netlify.app/docs/tasks/job/automated-tasks-with-cron-jobs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can refer to man page too.

@windsonsea windsonsea force-pushed the docsite3 branch 3 times, most recently from ceec747 to 9799369 Compare June 22, 2022 10:20
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'd like to see a bigger revision. This page is due a cleanup (see issue #4500). @windsonsea maybe we, Kubernetes SIG Docs, can help you make that bigger cleanup happen?

If we're revising this page, I recommend also putting in a note about the risk of setting .spec.concurrencyPolicy to Allow (which is the default): if your Job is still running after the next one is due to start, you can end up consuming lots of resources.

That can either harm availability or your wallet, depending on whether you autoscale your cluster.

setting .spec.concurrencyPolicy to Forbid or Replace can be a wiser choice in many cases.

@windsonsea windsonsea changed the title [en] correction for text consistency and title tags [en] discussions about automated-tasks-with-cron-jobs.md Jun 26, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2022
@windsonsea windsonsea force-pushed the docsite3 branch 3 times, most recently from 970e430 to 9e75c60 Compare June 26, 2022 10:27
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2022
@windsonsea
Copy link
Member Author

windsonsea commented Jun 26, 2022

@tengqm haha, did I solve this rebase issue by the following tries, right? 😺

PS G:\Project\k8s\k8s> history
Id CommandLine
  -- -----------
  17 git checkout main
  18 git fetch upstream
  19 git remote add upstream GIT_REPO
  20 git remote -v
  21 git fetch upstream
  22 git remote add upstream https://github.com/windsonsea/k8s.git
  23 git remote set-url upstream https://github.com/windsonsea/k8s.git
  24 git fetch upstream
  25 git rebase upstream/main
  26 git push
  27 git checkout docsite3
  28 git log
  29 git rebase -i main
  30 git status
  31 git rebase --continue
  32 git add
  33 git add .
  34 git status
  35 git rebase -i HEAD~10
  36 git rebase --continue
  37 git status
  38 git commit --amend --no-edit
  39 git push origin docsite3 -f

@tengqm
Copy link
Contributor

tengqm commented Jun 26, 2022

@windsonsea You only need to do git rebase -i main. There is no need to do git rebase -i HEAD~10.

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go.
/lgtm

Remove squash label since it's already squashed into one commit.
/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b2047f22787bb82963799f0474193b1095485f4

@kbhawkey
Copy link
Contributor

kbhawkey commented Jul 9, 2022

@kbhawkey
Copy link
Contributor

kbhawkey commented Jul 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit b3f2453 into kubernetes:main Jul 9, 2022
@windsonsea windsonsea deleted the docsite3 branch July 12, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants