Skip to content

Move what-is-kubernetes to overview page #35298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2022
Merged

Move what-is-kubernetes to overview page #35298

merged 5 commits into from
Aug 22, 2022

Conversation

@Rishit-dagli
Copy link
Contributor

Move https://kubernetes.io/docs/concepts/overview/what-is-kubernetes/ to https://kubernetes.io/docs/concepts/overview/

This PR also makes sure that:

  • a new redirect
  • make sure that the table of contents is no longer rendered

Fixes: #35251

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 23, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 23, 2022
@netlify
Copy link

netlify bot commented Jul 24, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ec4930
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62deb94a8ba261000894f540
😎 Deploy Preview https://deploy-preview-35298--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jul 24, 2022

/label refactor

Changes like this need a discussion across the team.

@k8s-ci-robot k8s-ci-robot added the refactor Indicates a PR with large refactoring changes e.g. removes files or moves content label Jul 24, 2022
sftim
sftim reviewed Jul 25, 2022
View reviewed changes
sftim
sftim reviewed Jul 25, 2022
View reviewed changes
sftim
sftim reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the intent here.
https://deploy-preview-35298--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/ looks much better than https://kubernetes.io/docs/concepts/overview/ (to me)

@Rishit-dagli Rishit-dagli requested a review from sftim July 25, 2022 15:43
@Rishit-dagli Rishit-dagli mentioned this pull request Aug 17, 2022
Closed
9 tasks
mehabhalodiya
mehabhalodiya approved these changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@mehabhalodiya mehabhalodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all pointers mentioned in #35251 (comment) has been addressed.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f773a288478ef14044b48c6000e9a01464b18dc5

@Rishit-dagli
Copy link
Contributor Author

/assign @kcmartin

Once this PR has been reviewed and has the lgtm label, please assign kcmartin for approval

sftim
sftim reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mehabhalodiya, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit dff7efc into kubernetes:main Aug 22, 2022
@windsonsea windsonsea mentioned this pull request Aug 23, 2022
Merged
@dipesh-rawat dipesh-rawat mentioned this pull request Sep 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@lavalamp lavalamp Awaiting requested review from lavalamp

2 more reviewers

@sftim sftim sftim left review comments

@mehabhalodiya mehabhalodiya mehabhalodiya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kcmartin kcmartin

@mehabhalodiya mehabhalodiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/concepts/overview/

6 participants

@Rishit-dagli @tengqm @k8s-ci-robot @sftim @mehabhalodiya @kcmartin