Skip to content

Conversation

@sftim
Copy link
Contributor

@sftim sftim commented Aug 25, 2022

After #35608 merged, I made commit 3403ffa to omit a link that wouldn't be live when @PushkarJ's blog article publishes.

The link won't work until we manually unhold kubernetes/contributor-site#330

Once the related implementation details article is published, we can reinstate the paragraph that hyperlinks to that article. This commit does that.

/area blog
/language en

/hold
until kubernetes/contributor-site#330 is merged

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 25, 2022
@sftim sftim changed the title Reinstate implementation details for CVE feed announcement. Reinstate implementation details for CVE feed announcement Aug 25, 2022
Once the related implementation details article is published, we can
reinstate the paragraph that hyperlinks to that article.
@sftim sftim force-pushed the 20220825_reinstate_cve_feed_announcement_link branch from ea66b67 to 31f7a48 Compare August 25, 2022 16:50
@netlify
Copy link

netlify bot commented Aug 25, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 31f7a48
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6307a86355fc570009ddabc0
😎 Deploy Preview https://deploy-preview-36292--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mtardy
Copy link
Member

mtardy commented Sep 7, 2022

Makes perfect sense to reinstate that paragraph when the article will be published, just make sure it's working in case the date change! :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ffd290e5f49bddda27f8864d547877e27cc25cb

@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

OK, as I'm a blog editor I'm going to self-approve this, and rely also on @mtardy's LGTM

@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@sftim
Copy link
Contributor Author

sftim commented Sep 7, 2022

From the 12th of September onwards, folks are welcome to unhold this. Even better if you first checked that both blog articles are already live before you do.

@reylejano
Copy link
Member

The person unholding this PR should check the link, https://kubernetes.dev/blog/2022/09/12/k8s-cve-feed-alpha, before unholding
As Tim mentioned, Sept 12 is the earliest we should unhold this PR
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor Author

sftim commented Sep 8, 2022

@rolfedh I saw your review #36292 (review)

If you'd like to propose these changes, you should open a brand new PR and ask @PushkarJ to review those. We avoid changing the author's words without their agreement.

@sftim
Copy link
Contributor Author

sftim commented Sep 8, 2022

I'll mark that feedback as resolved because it's not appropriate to add an extra purpose to this quite focused PR.

@rolfedh
Copy link
Contributor

rolfedh commented Sep 10, 2022

not appropriate to add an extra purpose

I misunderstood your request for a review as a request for language review.

@PushkarJ
Copy link
Member

With https://www.kubernetes.dev/blog/2022/09/12/k8s-cve-feed-alpha/ published it's time to merge this PR:

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 76898ba into kubernetes:main Sep 12, 2022
@sftim sftim deleted the 20220825_reinstate_cve_feed_announcement_link branch September 23, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants