-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Reinstate implementation details for CVE feed announcement #36292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate implementation details for CVE feed announcement #36292
Conversation
Once the related implementation details article is published, we can reinstate the paragraph that hyperlinks to that article.
ea66b67 to
31f7a48
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Makes perfect sense to reinstate that paragraph when the article will be published, just make sure it's working in case the date change! :) /lgtm |
|
LGTM label has been added. Git tree hash: 9ffd290e5f49bddda27f8864d547877e27cc25cb
|
|
OK, as I'm a blog editor I'm going to self-approve this, and rely also on @mtardy's LGTM |
|
/approve |
|
From the 12th of September onwards, folks are welcome to unhold this. Even better if you first checked that both blog articles are already live before you do. |
|
The person unholding this PR should check the link, https://kubernetes.dev/blog/2022/09/12/k8s-cve-feed-alpha, before unholding |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md
Show resolved
Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md
Show resolved
Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md
Show resolved
Hide resolved
|
@rolfedh I saw your review #36292 (review) If you'd like to propose these changes, you should open a brand new PR and ask @PushkarJ to review those. We avoid changing the author's words without their agreement. |
|
I'll mark that feedback as resolved because it's not appropriate to add an extra purpose to this quite focused PR. |
I misunderstood your request for a review as a request for language review. |
|
With https://www.kubernetes.dev/blog/2022/09/12/k8s-cve-feed-alpha/ published it's time to merge this PR: /unhold |
After #35608 merged, I made commit 3403ffa to omit a link that wouldn't be live when @PushkarJ's blog article publishes.
The link won't work until we manually unhold kubernetes/contributor-site#330
Once the related implementation details article is published, we can reinstate the paragraph that hyperlinks to that article. This commit does that.
/area blog
/language en
/hold
until kubernetes/contributor-site#330 is merged