Documentation for in-place pod resize feature #39845

vinaykul · 2023-03-07T20:46:08Z

Documentation for in-place pod resize feature. Ref: kubernetes/kubernetes#102884

vinaykul · 2023-03-17T23:43:06Z

/assign @sftim

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

vinaykul · 2023-03-19T03:41:49Z

@tengqm Thanks for the careful review, much appreciated! I fixed them (and hopefully didn't miss any of the items). PTAL.

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

tengqm · 2023-03-20T01:01:27Z

/label tide/merge-method-squash
/lgtm

k8s-ci-robot · 2023-03-20T01:01:34Z

LGTM label has been added.

Git tree hash: 90754a44e41d00cec39a6c8ed1f0629e8c5b5bd9

vinaykul · 2023-03-20T19:08:09Z

@tengqm I noticed a few missing things. Please review latest commit. thanks

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

tengqm · 2023-03-21T01:39:30Z

@vinaykul Please try keep this PR at a single commit, i.e., please squash your commits into one.

sftim

Thanks. With a few tweaks this should be OK to merge.

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

sftim · 2023-03-21T10:33:02Z

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

+The following changes enable in-place resize of container resources:
+- Container's resource **requests** and **limits** are now **mutable** for CPU
+and memory resources.
+- A new field named `allocatedResources` has been added to `containerStatuses`
+in the Pod's status to reflect the resources allocated to the pod's containers.
+- A new field named `resources` has been added to the Container's status. This
+field reflects the actual resource requests and limits that are configured on
+the running containers as reported by the container runtime.
+- A new field named `resize` has been added to the Pod's status to show the
+status of the last requested pending resize. It can have the following values:


Describe the current behavior, not the diff.

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

sftim · 2023-03-21T10:35:23Z

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

+
+Consider the following manifest for a Pod that has one Container.
+
+{{< codenew file="pods/qos/qos-pod.yaml" >}}


Consider making a new separate example manifest.

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

tengqm · 2023-03-22T06:35:16Z

content/en/docs/tasks/configure-pod-container/resize-container-resources.md

+- Container's resource **requests** and **limits** are now **mutable** for CPU
+and memory resources.


Not a strong opinion, but I'd like to format bulletin items by having the following lines indented. For example:

Suggested change

- Container's resource **requests** and **limits** are now **mutable** for CPU

and memory resources.

- Container's resource **requests** and **limits** are now **mutable** for CPU

and memory resources.

tengqm · 2023-03-22T06:35:41Z

/approve

k8s-ci-robot · 2023-03-22T06:35:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix issues from review feedback Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Better wording and formatting of overview section Add descriptions about allocatedResources, resources, and resize fields Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Apply suggestions from code review Co-authored-by: Qiming Teng <[email protected]>

Co-authored-by: Tim Bannister <[email protected]>

vinaykul · 2023-03-22T10:32:09Z

@sftim I fixed the issues you found. PTAL, thx

vinaykul · 2023-03-29T22:56:21Z

@sftim Please take a look, I believe I have addressed all issues you found.

tengqm · 2023-03-31T02:58:17Z

/lgtm

k8s-ci-robot · 2023-03-31T02:58:23Z

LGTM label has been added.

Git tree hash: 5b8e5b235780d8e07749df16f0d47cea7b0b497a

* Documentation for in-place pod resize feature Fix issues from review feedback Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Better wording and formatting of overview section Add descriptions about allocatedResources, resources, and resize fields Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Update content/en/docs/tasks/configure-pod-container/resize-container-resources.md Co-authored-by: Qiming Teng <[email protected]> Apply suggestions from code review Co-authored-by: Qiming Teng <[email protected]> * Simplify the changes by using bullet points * Apply suggestions from code review Co-authored-by: Tim Bannister <[email protected]> --------- Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Tim Bannister <[email protected]>

k8s-ci-robot added this to the 1.27 milestone Mar 7, 2023

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 7, 2023

k8s-ci-robot requested review from sftim and tengqm March 7, 2023 20:46

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 7, 2023

vinaykul force-pushed the dev-1.27 branch from d22bd09 to baccd6d Compare March 7, 2023 20:52

vinaykul mentioned this pull request Mar 10, 2023

In-Place Update of Pod Resources kubernetes/enhancements#1287

Open

95 tasks

vinaykul force-pushed the dev-1.27 branch 2 times, most recently from bb7d86c to b893d8b Compare March 17, 2023 23:41

vinaykul changed the title ~~Placeholder documentation for in-place pod resize feature~~ Documentation for in-place pod resize feature Mar 17, 2023

k8s-ci-robot assigned sftim Mar 17, 2023

tengqm reviewed Mar 18, 2023

View reviewed changes

tengqm reviewed Mar 20, 2023

View reviewed changes

content/en/docs/tasks/configure-pod-container/resize-container-resources.md Outdated Show resolved Hide resolved

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 20, 2023

k8s-ci-robot assigned tengqm Mar 20, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2023

k8s-ci-robot requested a review from tengqm March 20, 2023 19:06

vinaykul force-pushed the dev-1.27 branch 2 times, most recently from a1bc39f to e5ebc5a Compare March 20, 2023 19:32

tengqm reviewed Mar 21, 2023

View reviewed changes

content/en/docs/tasks/configure-pod-container/resize-container-resources.md Outdated Show resolved Hide resolved

tengqm reviewed Mar 21, 2023

View reviewed changes

vinaykul force-pushed the dev-1.27 branch 3 times, most recently from 2235f3c to d71d2e5 Compare March 21, 2023 03:58

sftim reviewed Mar 21, 2023

View reviewed changes

tengqm reviewed Mar 22, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023

vinaykul and others added 3 commits March 22, 2023 02:50

Simplify the changes by using bullet points

4348c37

Apply suggestions from code review

de7d756

Co-authored-by: Tim Bannister <[email protected]>

vinaykul force-pushed the dev-1.27 branch from 2c1a766 to de7d756 Compare March 22, 2023 10:30

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023

k8s-ci-robot merged commit a4eca1a into kubernetes:dev-1.27 Mar 31, 2023

sftim mentioned this pull request Apr 20, 2023

Not able to find which alpha feature gates for "Resize CPU and Memory Resources assigned to Containers" #40776

Closed


		Consider the following manifest for a Pod that has one Container.

		{{< codenew file="pods/qos/qos-pod.yaml" >}}

		- Container's resource requests and limits are now mutable for CPU
		and memory resources.

Documentation for in-place pod resize feature #39845

Documentation for in-place pod resize feature #39845

Conversation

vinaykul commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinaykul commented Mar 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinaykul commented Mar 19, 2023

Uh oh!

Uh oh!

tengqm commented Mar 20, 2023

Uh oh!

k8s-ci-robot commented Mar 20, 2023

Uh oh!

vinaykul commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tengqm commented Mar 21, 2023

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sftim Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sftim Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tengqm Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

vinaykul Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

tengqm commented Mar 22, 2023

Uh oh!

k8s-ci-robot commented Mar 22, 2023

Uh oh!

vinaykul commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinaykul commented Mar 29, 2023

Uh oh!

tengqm commented Mar 31, 2023

Uh oh!

k8s-ci-robot commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

vinaykul commented Mar 7, 2023 •

edited

Loading

vinaykul commented Mar 22, 2023 •

edited

Loading