-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add Documentation for CRD Validation Ratcheting #41737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for CRD Validation Ratcheting #41737
Conversation
|
Hello @alexzielenski 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you! |
1707b46 to
7cf6eed
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
Thanks @katcosgrove! I've updated the PR to document the feature gate on the feature gates table and descriptions. PTAL |
|
/sig api-machinery |
sftim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Please document the feature - you need to change https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/ and https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/ as well as the feature gates page.
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
sftim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't understand how the feature works; I've guessed and have made suggestions to clarify those guessed qualities.
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
|
comments addressed, preview looks good locally but I dont see how to access the CI preview |
|
/approve Thanks! |
|
LGTM label has been added. Git tree hash: 3b7dfbe3d567105ddcd76b366228904a52dbba80
|
|
To see the preview, click on Details next to the check named |
|
Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ation Add Documentation for CRD Validation Ratcheting
Adds feature gate documentation for KEP-4008