Skip to content

Conversation

@alexzielenski
Copy link
Member

@alexzielenski alexzielenski commented Jun 22, 2023

Adds feature gate documentation for KEP-4008

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm June 22, 2023 22:18
@katcosgrove
Copy link
Contributor

Hello @alexzielenski 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@netlify
Copy link

netlify bot commented Jul 25, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 75ec818
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64d265486a18aa0008a89e20

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2023
@alexzielenski alexzielenski changed the title [WIP] Add Documentation for CRD Validation Ratcheting Add Documentation for CRD Validation Ratcheting Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 25, 2023
@alexzielenski
Copy link
Member Author

alexzielenski commented Jul 25, 2023

Thanks @katcosgrove! I've updated the PR to document the feature gate on the feature gates table and descriptions. PTAL

@Rishit-dagli
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 26, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't understand how the feature works; I've guessed and have made suggestions to clarify those guessed qualities.

@alexzielenski
Copy link
Member Author

comments addressed, preview looks good locally but I dont see how to access the CI preview

@jpbetz
Copy link
Contributor

jpbetz commented Aug 8, 2023

/approve
/lgtm
For technical content

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b7dfbe3d567105ddcd76b366228904a52dbba80

@sftim
Copy link
Contributor

sftim commented Aug 8, 2023

To see the preview, click on Details next to the check named deploy/netlify

@sftim
Copy link
Contributor

sftim commented Aug 8, 2023

Thanks
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2cf620 into kubernetes:dev-1.28 Aug 8, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
…ation

Add Documentation for CRD Validation Ratcheting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants