Skip to content

Add feature gate to pod vertical resource scaling example #45350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add feature gate to pod vertical resource scaling example #45350

merged 1 commit into from
Apr 22, 2024

Conversation

@dshebib
Copy link
Contributor

@dshebib dshebib commented Feb 26, 2024

Mentions the InPlacePodVerticalScaling feature gate in the Pod resource specification example. Fixes #40776, #41365, #45079.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim February 26, 2024 16:15
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e64910f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65f0aff50a416f00084d2bfe
😎 Deploy Preview https://deploy-preview-45350--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim previously requested changes Feb 26, 2024
View reviewed changes
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@dshebib
Copy link
Contributor Author

dshebib commented Feb 26, 2024

As a side note, would it help to edit https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler#limits-control to mention that the reason for maintaing the ratio of limits to requests is to maintain the qos of the pod?

tengqm
tengqm reviewed Feb 27, 2024
View reviewed changes
sftim
sftim reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e6fe1f0007266f66635e833a9122cc6fd9ee02fe

@sftim
Copy link
Contributor

sftim commented Feb 27, 2024

As a side note, would it help to edit https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler#limits-control to mention that the reason for maintaing the ratio of limits to requests is to maintain the qos of the pod?

Sounds reasonable. SIG Autoscaling can confirm if that's the true intent there.

@sftim sftim dismissed their stale review February 28, 2024 12:11

Review was stale

@dshebib dshebib force-pushed the podResourceInPlaceExampleFix branch from 3f2a919 to 2789a15 Compare February 28, 2024 18:42
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim February 28, 2024 18:42
@dshebib
Copy link
Contributor Author

dshebib commented Mar 6, 2024

@sftim

sftim
sftim reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9a942431ab7182d80cf237001282975b929c119

@reylejano
Copy link
Member

@dshebib , what do you think of @sftim's suggestion

@dshebib dshebib force-pushed the podResourceInPlaceExampleFix branch from 2789a15 to 23b6bc7 Compare March 12, 2024 15:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 12, 2024 15:52
@dshebib dshebib force-pushed the podResourceInPlaceExampleFix branch from 23b6bc7 to e64910f Compare March 12, 2024 19:41
sftim
sftim reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d46d78026fc92fb8175055cef654f4f861aa779

@reylejano
Copy link
Member

Thank you for addressing comments
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit a2d0b70 into kubernetes:main Apr 22, 2024
@vaibhav2107 vaibhav2107 mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

+1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not able to find which alpha feature gates for "Resize CPU and Memory Resources assigned to Containers"

5 participants

@dshebib @k8s-ci-robot @sftim @reylejano @tengqm