Cannot access request argument with HTTP protocol on GET route

[Aschen]

Description

index, collection and other arguments are not present in request input while using the HTTP protocol of the SDK.

I suspect the URL to be incorrectly created by the SDK Http protocol since the generated route is GET

Backend

app.controller.register("efficient", {
  actions: {
    "efficient": {
      handler: async (request: KuzzleRequest) => {
console.log(request.input.args);
if (request.input.args.index === undefined) {
  throw new Error('No index');
}
      }
    }
  }
})

Client (SDK)

import { Kuzzle, Http } from 'kuzzle-sdk';

const kuzzle = new Kuzzle(new Http('localhost'));

await kuzzle.query({
    controller: 'efficient',
    action: 'efficient',
    index: "index",
    collection: "collection",
    body: { hey: "hey" },
});

[alexandrebouthinon]

I successfully reproduce this but this is only the case when custom arguments are named:

• collection
• index
• meta
• headers
• controller
• action
• requestId

This is because they are present in a "boilerplate" payload used to compare with the given user request and forge the final request to send:

sdk-javascript/src/protocols/Http.ts

Lines 264 to 283 in 6aaf6e1

	for (const key of Object.keys(request)) {
	const value = request[key];
	if (key === "body") {
	if (method === "GET") {
	Object.assign(queryArgs, value);
	} else {
	payload.body = JSON.stringify(value);
	}
	} else if (key === "jwt") {
	payload.headers.authorization = "Bearer " + value;
	} else if (key === "volatile") {
	payload.headers["x-kuzzle-volatile"] = JSON.stringify(value);
	} else if (Object.prototype.hasOwnProperty.call(payload, key)) {
	payload[key] = value;
	} else if (value !== undefined && value !== null) {
	queryArgs[key] = value;
	}
	}

I made a patch here. I find it quite dirty but at the same time I have the impression that we don't have much choice to manage this edge case. Your review and suggestions are welcomed 😃

[Aschen]

@alexandrebouthinon I saw your fix and it seems good to me 👍

True to say this part is already dirty and there is not much to do to make it any cleaner 🙈 So if there is tests then it's ok at least