WebSocket support #100
Merged
WebSocket support #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: package.json
Current coverage is 100% (diff: 100%)@@ develop #100 diff @@
=====================================
Files 11 15 +4
Lines 1446 1627 +181
Methods 228 278 +50
Messages 0 0
Branches 365 393 +28
=====================================
+ Hits 1446 1627 +181
Misses 0 0
Partials 0 0
|
|
+1 |
1 similar comment
|
+1 |
| * @param index - Database index | ||
| * | ||
| * @constructor | ||
| * @param address - Server name or IP Address to the Kuzzle instance |
There was a problem hiding this comment.
Shouldn't we rather use host instead of address?
Looks to me to be more standard and more accurate.
There was a problem hiding this comment.
Done. I've also fixed a potential bug with the off function in websocket wrappers (node + browser)
|
Apart from the host/address naming thing, +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pure WebSocket capabilities to the Javascript SDK, while still supporting SocketIO to ensure compatibility with older browsers.
Unrelated changes
Kuzzle.queryis invoked without a query argument. Now throws an error when such a case occursresponseCallbackJSDoc