Webpack packaging #102
Merged
Webpack packaging #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ develop #102 diff @@
=====================================
Files 15 15
Lines 1627 1627
Methods 278 278
Messages 0 0
Branches 393 393
=====================================
Hits 1627 1627
Misses 0 0
Partials 0 0
|
package.json
Outdated
| "node-uuid": "1.4.7", | ||
| "ora": "^0.3.0", | ||
| "utf-8-validate": "^1.2.1", | ||
| "webpack": "^1.13.1", |
There was a problem hiding this comment.
shouldn't webpack be a devDep ?
|
LGTM |
Ora is used to display a spinner in the console while the build is performed.
|
+1 |
1 similar comment
|
+1 |
jenow
added a commit
that referenced
this pull request
Mar 8, 2018
jenow
added a commit
that referenced
this pull request
Mar 13, 2018
# Conflicts: # src/Kuzzle.js # src/networkWrapper/protocols/abstract/realtime.js # test/network/offlineQueue.test.js # test/network/query.test.js
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Grunt and sets Webpack as default package bundler for browser use.
Builds are launched via
and builds are dropped into
dist/.Built files still need some testing IMHO, since some external libraries are excluded (
noParse: [/wsnode\.js/, /crypto/, /buffer/, /node-uuid/]) and I'm not sure everything works fine.